Skip to content

fix: prefer serial credentials over personal-license when both are set #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frostebite merged 1 commit into from
Aug 27, 2026
+25 −3
Merged

fix: prefer serial credentials over personal-license when both are set #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dist/platforms/mac/steps/activate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,15 @@ ACTIVATE_MAX_ATTEMPTS="${UNITY_LICENSE_RETRY_MAX_ATTEMPTS:-4}"
ACTIVATE_RETRY_DELAY_SECONDS=20
ACTIVATE_TRANSIENT_LICENSE_ERROR_PATTERN='TimeoutPolicy did not complete|Access token is unavailable|entitlement groups and 0 free entitlements|License activation has failed|No valid Unity Editor license found|License is not active'

if [[ -n "$UNITY_LICENSE" ]] || [[ -n "$UNITY_LICENSE_FILE" ]]; then
# Serial mode is preferred over personal-license (below) whenever both are
# configured: a manually-activated .ulf is bound to the machine fingerprint
# of whatever machine originally requested it, which real CI evidence shows
# genuinely doesn't match every runner - confirmed via unity-test-runner's
# own CI, where the identical .ulf activates cleanly through this same
# script's ubuntu counterpart but fails windows with "Machine bindings
# don't match" every single time. Serial credentials have no such
# constraint, so given a choice, prefer them.
if [[ -z "$UNITY_SERIAL" || -z "$UNITY_EMAIL" || -z "$UNITY_PASSWORD" ]] && { [[ -n "$UNITY_LICENSE" ]] || [[ -n "$UNITY_LICENSE_FILE" ]]; }; then
#
# PERSONAL LICENSE MODE
#
Expand Down
7 changes: 6 additions & 1 deletion dist/platforms/ubuntu/steps/activate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@ UNITY_ACTIVATE_MAX_ATTEMPTS="${UNITY_LICENSE_RETRY_MAX_ATTEMPTS:-4}"
UNITY_ACTIVATE_RETRY_DELAY_SECONDS=20
UNITY_ACTIVATE_TRANSIENT_PATTERN='TimeoutPolicy did not complete|Access token is unavailable|entitlement groups and 0 free entitlements|License activation has failed|No valid Unity Editor license found|License is not active'

if [[ -n "$UNITY_LICENSE" ]] || [[ -n "$UNITY_LICENSE_FILE" ]]; then
# Serial mode is preferred over personal-license (below) whenever both are
# configured - see mac/steps/activate.sh's matching comment: a manually-
# activated .ulf is bound to the machine fingerprint of whatever machine
# originally requested it, which doesn't necessarily match every runner.
# Serial credentials have no such constraint, so given a choice, prefer them.
if [[ -z "$UNITY_SERIAL" || -z "$UNITY_EMAIL" || -z "$UNITY_PASSWORD" ]] && { [[ -n "$UNITY_LICENSE" ]] || [[ -n "$UNITY_LICENSE_FILE" ]]; }; then
#
# PERSONAL LICENSE MODE
#
Expand Down
11 changes: 10 additions & 1 deletion dist/platforms/windows/activate.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,16 @@ $MaxAttempts = if ($Env:UNITY_LICENSE_RETRY_MAX_ATTEMPTS) { [int]$Env:UNITY_LICE
$RetryDelaySeconds = 20
$TransientPattern = 'TimeoutPolicy did not complete|Access token is unavailable|entitlement groups and 0 free entitlements|License activation has failed|No valid Unity Editor license found|License is not active'

if ($Env:UNITY_LICENSE -or $Env:UNITY_LICENSE_FILE) {
# Serial mode is preferred over personal-license (below) whenever both are
# configured - see mac/steps/activate.sh's matching comment: a manually-
# activated .ulf is bound to the machine fingerprint of whatever machine
# originally requested it, which real CI evidence shows genuinely doesn't
# match every runner (confirmed "Machine bindings don't match" on windows
# specifically, with the identical .ulf activating cleanly elsewhere).
# Serial credentials have no such constraint, so given a choice, prefer them.
$HasSerialCredentials = $Env:UNITY_SERIAL -and $Env:UNITY_EMAIL -and $Env:UNITY_PASSWORD

if ((-not $HasSerialCredentials) -and ($Env:UNITY_LICENSE -or $Env:UNITY_LICENSE_FILE)) {
#
# PERSONAL LICENSE MODE
#
Expand Down
Loading