fix(mac): UnityLicensingClient path for Unity 6000.3+, port return-floating - #196
Conversation
…oating Ports game-ci/unity-builder#842 (community contribution by alexis-gervacio): Unity 6000.3+ moved UnityLicensingClient from Contents/Frameworks to Contents/Helpers (https://docs.unity.com/en-us/licensing-server/client-config). A hardcoded Frameworks path 127'd ("No such file or directory") on every 6000.3+ mac build using a license server. Both scripts now detect the version and pick the right subdirectory. Also fixes a gap found while porting this: return_license.sh had no UNITY_LICENSING_SERVER branch at all - activate.sh's own UNITY_LICENSING_SERVER branch acquires a floating license via UnityLicensingClient, but with no matching return step, that license seat was never released back to the server after a single mac floating-license build. unity-builder's own return_license.sh has this branch; this repo's copy was missing it entirely. Since unity-builder is now a thin wrapper around this CLI (game-ci/unity-builder#844), engine-specific fixes like this belong here instead - unity-builder#842 is being closed in favor of this PR.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Ports game-ci/unity-builder#842 (community contribution by @alexis-gervacio): Unity 6000.3+ moved UnityLicensingClient from `Contents/Frameworks` to `Contents/Helpers` (Unity docs). A hardcoded Frameworks path failed with exit 127 ("No such file or directory") on every 6000.3+ mac build using a license server. Both scripts now detect the version and pick the right subdirectory.
Also fixes a gap found while porting this: `return_license.sh` had no `UNITY_LICENSING_SERVER` branch at all - `activate.sh`'s own branch acquires a floating license via UnityLicensingClient, but with no matching return step, that license seat was never released back to the server after a single mac floating-license build. unity-builder's own `return_license.sh` has this branch; this repo's copy was missing it entirely.
Since unity-builder is now a thin wrapper around this CLI (game-ci/unity-builder#844), engine-specific fixes like this belong here instead - unity-builder#842 is being closed in favor of this PR.
Test plan