Fix a bug in catalog update - #985
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug is that build_support/catalog/update.py does not build a fresh catalog from Git directly. It calls:
gbt.catalog.games(include_descriptions=True), so it uses whatever pygambit your current python imports. If that Python has an old installed/editable pygambit, or an oldbuild/lib.../pygambit/catalog_data, it will “remember” deleted games. The remembering is severe: even if one deletes the gambit locally and git clone a new one, reinstalling will still remember old games. Now this has been fixed by updatingupdate.py.The ruff error has also been fixed.