Enforce unique, nonempty labels for outcomes - #982
Merged
Conversation
d-kad
added
c++
…tional parameter that is actually required is not Pythonic!)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
Description of the changes in this PR
Enforces label rules for outcomes, following the same pattern as players (#979) and strategies (#981).
An outcome label must be nonempty, valid, and unique within the game, enforced in
GameRep::CheckOutcomeLabel, called at creation (NewOutcome) and relabel (SetLabel);violations raise
ValueError.add_outcomerequires a label and relies on the C++ enforcement;a failed creation with an invalid or duplicate label leaves the game unchanged.