Remove deprecated Tornado current-loop APIs in WebGL server thread#647
Draft
Copilot wants to merge 2 commits into
Draft
Remove deprecated Tornado current-loop APIs in WebGL server thread#647Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix tornado warnings in serve.py for deprecation
Remove deprecated Tornado current-loop APIs in WebGL server thread
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes Tornado deprecation warnings emitted by
cortex/webgl/serve.pywhen running WebGL/headless tests.WebApp.run()previously used deprecated current-loop mutation methods (clear_current/make_current).Runtime loop initialization
WebApp.run()now gets the thread-local loop viatornado.ioloop.IOLoop.current()instead of constructing anIOLoopand mutating global current-loop state.Application→HTTPServer→listen→start).Focused regression coverage
cortex/tests/test_webgl_serve.pywith a targeted test that monkeypatchesIOLoop.current()and assertsWebAppuses that loop for startup.Original prompt
Created from VS Code.