Store relevant JSON values in the history table

[gagnieray]

No description provided.

[gagnieray]

@trasher, when you have a moment, could you please take a look at my scripts for updating the database schema? I’m considering adding the ability to filter the payment history. So I needed to extract values from the stored JSON query. And in addition, for MySQL/MariaDB, I also updated the character set and the encoding for collations. Thanks!

[trasher]

I ran the mysql install script from develop branch; and tried to update; I had several errors on first lines:

• galette_stripe_types_cotisation_prices table does not exist
• CHANGE COLUMN comment comments field is already names comments
• CHANGE COLUMN metadata request text there is no such column

It looks like issues are the same on master branch.
Did I miss something?

[gagnieray]

Well, in my opinion, the "normal" update path should be from version 0.0.3 (compatible with Galette 9.4.2) to version 1.0.0 (compatible with Galette 1.3.0) without going through the pre-releases (because I’ve always advised against using pre-releases in production).

But I’m probably wrong to think about it that way 😕

In practice, some people will inevitably have already used the alpha1 version in production, and I should take that into account. In that case, it might be badly received if I tell them to reinstall the plugin without using an update. What do you think? 🤔

In any case, to test the update under the conditions currently planned, you need first to roll back the database to the state it was in for version 0.0.3:

CREATE TABLE galette_stripe_types_cotisation_prices ( 
  dummy_column text 
);

ALTER TABLE galette_stripe_history
  CHANGE COLUMN comments comment VARCHAR(255),
  CHANGE COLUMN request metadata TEXT
  DROP COLUMN payer_name;

[trasher]

OK, I indeed had missed something... I took the SQL script from the main branch and not from the latest stable. Tested again with the correct script; update went fine!

But I’m probably wrong to think about it that way 😕

No, you're right. alpha versions of the plugin are not designed to be used in production; just as 1.3-dev Galette ;)

Upgrading from a development snapshot has never been supported in Galette and plugins (I often not release any alpha/beta so I do not have to deal with that kind of issues :p).

[trasher]

LGTM. I cannot test JSON migration itself; I do not have any data.