Skip to content

Fix error in floops position mapping - #430

Merged
torrinba merged 3 commits into
masterfrom
ssd/fix_floops_mapping_error
Jul 28, 2026
Merged

Fix error in floops position mapping#430
torrinba merged 3 commits into
masterfrom
ssd/fix_floops_mapping_error

Conversation

@AreWeDreaming

@AreWeDreaming AreWeDreaming commented Jul 28, 2026 •
edited by torrinba
Loading

Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Tested against imas_composer see GA-FDP/imas_composer#88

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged.
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.2 → 0.94.3 for bug fixes, 0.94.2 → 0.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

Additional Notes

@AreWeDreaming
AreWeDreaming requested a review from torrinba July 28, 2026 22:09
@AreWeDreaming AreWeDreaming mentioned this pull request Jul 28, 2026
Merged
torrinba
torrinba reviewed Jul 28, 2026
View reviewed changes
Comment thread omas/machine_mappings/d3d.json Outdated
torrinba
torrinba approved these changes Jul 28, 2026
View reviewed changes

@torrinba torrinba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks for fixing this @AreWeDreaming

@torrinba
torrinba merged commit 13b1a01 into master Jul 28, 2026
4 of 8 checks passed
@torrinba
torrinba deleted the ssd/fix_floops_mapping_error branch July 28, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@torrinba torrinba torrinba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AreWeDreaming @torrinba