docs: correct daily/hourly sink filename format in comments - #3637
Merged
gabime merged 1 commit intoJul 24, 2026
Conversation
The daily_filename_calculator and hourly_filename_calculator produce filenames using an underscore separator (e.g. basename_YYYY-MM-DD.ext and basename_YYYY-MM-DD_HH.ext), but the surrounding comments described the format with a dot separator (basename.YYYY-MM-DD.ext) and, for the hourly sink, a dash before the hour. Update the comments to match the actual output produced by calc_filename.
Owner
|
Thanks @dvirarad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
daily_filename_calculatorandhourly_filename_calculatorbuild filenames with an underscore separator (basename_YYYY-MM-DD.extandbasename_YYYY-MM-DD_HH.ext), but the accompanying comments described the format with a dot separator — and, for the hourly sink, a dash before the hour. This updates the comments to match the output actually produced bycalc_filename(see the regex intests/test_daily_logger.cpp). Comments only; no behavior change.