Skip to content

Fix bugs and some improvements - #6

Merged
fusepilot merged 9 commits into
fusepilot:masterfrom
adobe-extension-tools:master
Nov 5, 2018
Merged

Fix bugs and some improvements#6
fusepilot merged 9 commits into
fusepilot:masterfrom
adobe-extension-tools:master

Conversation

@vespakoen

Copy link
Copy Markdown
Collaborator
  • yarn -> npm
  • fix node modules copying
  • only bundle once, and on package.json change
  • move copyDependencies and copyIcons to utils

- Got rid of manifest.json
- Fixed node_modules copying
- Moved `copyDependencies` and `copyIcons` to utils

@fusepilot fusepilot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, really awesome stuff! Really appreciate your help. Just one question about removing manifest.json.

Comment thread src/index.js
Comment thread src/index.js Outdated
@vespakoen

vespakoen commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator Author

Just added some code that will add the (final) config values to the process.env, making them available in CEP + ExtendScript code. and added a debugPorts config that looks like this:

"cep": {
  "debugPorts": {
    "AEFT": 3001
  }
}

Or by using environment variables

export DEBUG_PORT_AEFT=3001

@fusepilot
fusepilot merged commit 442c812 into fusepilot:master Nov 5, 2018
@fusepilot

Copy link
Copy Markdown
Owner

Let's try this out. Published as 1.2.0. Thanks Koen.

@vespakoen

Copy link
Copy Markdown
Collaborator Author

Sweet! I think we also need to publish this one then:

fusepilot/parcel-plugin-cep-starter#4

Guess they are dependent on each other (didn't check however).

I'll be keeping an eye on incoming issues ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants