Fix bugs and some improvements - #6
Merged
Merged
Conversation
vespakoen
commented
Oct 18, 2018
Collaborator
- yarn -> npm
- fix node modules copying
- only bundle once, and on package.json change
- move copyDependencies and copyIcons to utils
- Got rid of manifest.json - Fixed node_modules copying - Moved `copyDependencies` and `copyIcons` to utils
fusepilot
requested changes
Oct 19, 2018
fusepilot
left a comment
Owner
There was a problem hiding this comment.
Again, really awesome stuff! Really appreciate your help. Just one question about removing manifest.json.
Co-Authored-By: vespakoen <k.schmeets@gmail.com>
Collaborator
Author
|
Just added some code that will add the (final) config values to the process.env, making them available in CEP + ExtendScript code. and added a debugPorts config that looks like this: Or by using environment variables |
Owner
|
Let's try this out. Published as |
Collaborator
Author
|
Sweet! I think we also need to publish this one then: fusepilot/parcel-plugin-cep-starter#4 Guess they are dependent on each other (didn't check however). I'll be keeping an eye on incoming issues ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.