Repository navigation
build(lint): allow rest siblings in no-unused-vars - #40
Conversation
no-unused-vars is already enabled by the oxlint correctness category.
Set ignoreRestSiblings so the key-omitting pattern
const { password, ...safeUser } = user is allowed, matching effort-or-luck.
Refs furedea/agent-config#74
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review summary: no findings. This PR adds one line to Blocking findings (P0/P1): 0 |
概要
.oxlintrc.jsonのrulesに"no-unused-vars": ["warn", { "ignoreRestSiblings": true }]を追加します.effort-or-luckと同じ 1 行の書式,同じ位置(max-paramsの次)です.理由
no-unused-varsは oxlint の correctness カテゴリでもともと有効です.ignoreRestSiblingsだけでした.ignoreRestSiblingsは,キーを取り除く一般的な書き方const { password, ...safeUser } = user;を許可します.effort-or-luckはすでにこの設定を持っており,オーナーが「すべての TS repo で同じ書き方にする」と決めました.新規ルールの違反
なし.
pnpm run lintは警告・エラーとも 0 件でした.既存の ignore は削除していません.検証
dev shell(
nix develop -c)で実行し,すべて成功しました.pnpm run lintpnpm run format:checkpnpm run typecheckpnpm run testRefs furedea/agent-config#74
🤖 Generated with Claude Code