Skip to content

build(lint): allow rest siblings in no-unused-vars - #40

Merged
furedea merged 1 commit into
mainfrom
build/no-unused-vars-ignore-rest-siblings
Nov 10, 2026
Merged

furedea merged 1 commit into
mainfrom
build/no-unused-vars-ignore-rest-siblings

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

概要

.oxlintrc.json の rules に "no-unused-vars": ["warn", { "ignoreRestSiblings": true }] を追加します.effort-or-luck と同じ 1 行の書式,同じ位置(max-params の次)です.

理由

  • no-unused-vars は oxlint の correctness カテゴリでもともと有効です.
  • repo 間の差は ignoreRestSiblings だけでした.
  • ignoreRestSiblings は,キーを取り除く一般的な書き方 const { password, ...safeUser } = user; を許可します.
  • effort-or-luck はすでにこの設定を持っており,オーナーが「すべての TS repo で同じ書き方にする」と決めました.

新規ルールの違反

なし.pnpm run lint は警告・エラーとも 0 件でした.既存の ignore は削除していません.

検証

dev shell(nix develop -c)で実行し,すべて成功しました.

コマンド 結果
pnpm run lint 成功
pnpm run format:check 成功
pnpm run typecheck 成功
pnpm run test 1 passed

Refs furedea/agent-config#74

🤖 Generated with Claude Code

no-unused-vars is already enabled by the oxlint correctness category.
Set ignoreRestSiblings so the key-omitting pattern
const { password, ...safeUser } = user is allowed, matching effort-or-luck.

Refs furedea/agent-config#74

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 10, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T17:02:15.591190Z
We couldn’t complete this review. Comment @codex review to try again.
9333515 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

Copy link
Copy Markdown

Review summary: no findings.

This PR adds one line to .oxlintrc.json: no-unused-vars with ignoreRestSiblings: true. The severity stays warn, the same as oxlint's default for the correctness category, so the only change is that rest-sibling destructuring is now allowed. The lint script doesn't use --deny-warnings, so CI behaves the same. No tests are needed for a lint config change.

Blocking findings (P0/P1): 0

@furedea
furedea merged commit 7da6916 into main Nov 10, 2026
17 of 19 checks passed
@furedea
furedea deleted the build/no-unused-vars-ignore-rest-siblings branch November 10, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant