Skip to content

build: enable oxlint no-explicit-any and consistent-type-imports - #39

Merged
furedea merged 1 commit into
mainfrom
build/74-oxlint
Nov 10, 2026
Merged

furedea merged 1 commit into
mainfrom
build/74-oxlint

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Refs furedea/agent-config#74

概要

段階 1B(既存 linter の規則を有効化)の template-typescript 分..oxlintrc.json に oxlint の typescript/no-explicit-any と typescript/consistent-type-imports を error で追加した.no-console と vitest の style 規則は style skill に根拠がないため有効化していない.

規則の対応表

規則 ID 元の場所 元の規則(原文) 判定 実装 例のテスト 元の文章
typescript/no-explicit-any agents/skills/typescript-style/references/types.md:49 Do not use any; use unknown and narrow. 既存 linter(oxlint typescript/no-explicit-any) .oxlintrc.json 悪 1(any 引数を含む一時ファイルが検出された) 残して併記
typescript/consistent-type-imports agents/skills/typescript-style/references/code_style.md:11 Use import type for type-only imports, as verbatimModuleSyntax requires. 既存 linter(oxlint typescript/consistent-type-imports) .oxlintrc.json 悪 1(値 import された型が import type に自動修正された) 残して併記

違反数(有効化前 / 後)

規則 有効化で出る違反(事前調査) 修正後
typescript/no-explicit-any 0 0
typescript/consistent-type-imports 0 0

修正対象がないため,設定のみのコミット 1 つ.

検証

  • pnpm exec oxlint src/index.ts src/index.test.ts vitest.config.ts: 違反 0
  • pnpm run format:check: 通過
  • pnpm run test: 1 件通過
  • 規則が実際に働くことは,any と型だけの値 import を含む一時ファイルで確認した.no-explicit-any が検出し,consistent-type-imports は --fix で import type に直した.この一時ファイルはコミットしていない.

計画との差

なし.

🤖 Generated with Claude Code

Enforce the typescript-style rules "do not use any" (types.md:49) and
"use import type for type-only imports" (code_style.md:11) mechanically.
Zero violations in the current sources.

Refs furedea/agent-config#74

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 9, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T15:34:08.123634Z
We couldn’t complete this review. Comment @codex review to try again.
f8c1968 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Review summary

No findings.

This PR adds two rules to .oxlintrc.json: typescript/consistent-type-imports and typescript/no-explicit-any, both set to error. Both are standard oxlint rules, and the typescript plugin they need is already enabled. They sit in alphabetical order with the other typescript/* rules. The repo uses verbatimModuleSyntax, so consistent-type-imports matches it.

Blocking findings (P0/P1): 0.

Note: I reviewed by reading the diff only. I did not run oxlint in this environment.

@furedea
furedea merged commit 0428c9a into main Nov 10, 2026
17 of 19 checks passed
@furedea
furedea deleted the build/74-oxlint branch November 10, 2026 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant