Repository navigation
build: enable oxlint no-explicit-any and consistent-type-imports - #39
Conversation
Enforce the typescript-style rules "do not use any" (types.md:49) and "use import type for type-only imports" (code_style.md:11) mechanically. Zero violations in the current sources. Refs furedea/agent-config#74 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Review summaryNo findings. This PR adds two rules to Blocking findings (P0/P1): 0. Note: I reviewed by reading the diff only. I did not run |
Refs furedea/agent-config#74
概要
段階 1B(既存 linter の規則を有効化)の template-typescript 分.
.oxlintrc.jsonに oxlint のtypescript/no-explicit-anyとtypescript/consistent-type-importsをerrorで追加した.no-consoleと vitest の style 規則は style skill に根拠がないため有効化していない.規則の対応表
typescript/no-explicit-anyagents/skills/typescript-style/references/types.md:49any; useunknownand narrow.typescript/no-explicit-any).oxlintrc.jsonany引数を含む一時ファイルが検出された)typescript/consistent-type-importsagents/skills/typescript-style/references/code_style.md:11import typefor type-only imports, asverbatimModuleSyntaxrequires.typescript/consistent-type-imports).oxlintrc.jsonimport typeに自動修正された)違反数(有効化前 / 後)
typescript/no-explicit-anytypescript/consistent-type-imports修正対象がないため,設定のみのコミット 1 つ.
検証
pnpm exec oxlint src/index.ts src/index.test.ts vitest.config.ts: 違反 0pnpm run format:check: 通過pnpm run test: 1 件通過anyと型だけの値 import を含む一時ファイルで確認した.no-explicit-anyが検出し,consistent-type-importsは--fixでimport typeに直した.この一時ファイルはコミットしていない.計画との差
なし.
🤖 Generated with Claude Code