Skip to content

ci: add a setup composite action for the TypeScript jobs - #37

Closed
furedea-agent[bot] wants to merge 2 commits into
mainfrom
ci/setup-composite-action
Closed

furedea-agent[bot] wants to merge 2 commits into
mainfrom
ci/setup-composite-action

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

概要

ci.yml の 5 ジョブ(lint,format,typecheck,test,audit)で重複していた準備手順を,ローカルの composite action .github/actions/setup にまとめました.

項目 内容
新規 .github/actions/setup/action.yml(pnpm,Node.js 22.23.3,pnpm install --frozen-lockfile)
変更 ci.yml の 5 ジョブが Setup workspace を 1 回呼ぶ
固定 pnpm/action-setup と actions/setup-node は元と同じ full SHA
変更なし ジョブ ID と名前(必須チェック all-green に影響なし),needs

判断

  • uses: ./.github/actions/setup に # zizmor: ignore[self-repository] を付けました.actionlint が $/ 構文に未対応のためです(reusable-workflows#17).agent-config の install-agent-harness と同じ扱いです.

関連

Refs furedea/reusable-workflows#6

🤖 Generated with Claude Code

furedea and others added 2 commits November 9, 2026 21:03
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 9, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T12:09:24.085011Z 0c5120b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Review summary: No findings.

I checked whether this refactor behaves the same as the old workflow:

  • The composite action at .github/actions/setup/action.yml runs the same three steps as before (pnpm/action-setup, actions/setup-node with Node 22.23.3 and the pnpm cache, then pnpm install --frozen-lockfile). Both actions use the same full commit SHAs as before.
  • shell: bash is set on the install step, which composite run steps require.
  • In all five jobs (lint, format, typecheck, test, audit), checkout runs before the local uses: ./.github/actions/setup step, so the action file exists when the step runs.
  • The job IDs and the needs list for all-green did not change.
  • The file names pass the .ls-lint.yml rules, and Renovate's default github-actions manager also picks up files under .github/actions/*.

No tests are needed beyond the CI run itself, which exercises the new action.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 0c5120b5a6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@furedea-agent

furedea-agent Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Closing: CI tools will come from the flake dev shell instead of setup actions (plan in furedea/reusable-workflows). The composite action is no longer needed.

@furedea-agent furedea-agent Bot closed this Nov 9, 2026
@furedea-agent
furedea-agent Bot deleted the ci/setup-composite-action branch November 9, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant