Repository navigation
ci: run the Rust tools from the flake dev shell - #17
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Review summaryNo findings. I didn't post any inline comments. What I checked:
Blocking findings: 0 |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
概要
CI の Rust のツールを,flake の devShell から動かす形にする.手元と CI で同じ版になり,
flake.lockで中身が固定される.変更
aarch64-darwinに加えてx86_64-linuxでも使えるようにした(genAttrs).ツールは元から揃っていたci.ymllint,format,test,auditからsetup-rust-toolchain,cargo-deny-action,cargo-macheteを削除nix-setup(v1.3.0,SHA 固定)→run.defaults.run.shellはnix develop --command bash -eo pipefail {0}(job ごと.all-greenは nix なしで動かすため)all-greenの needsCI の時間
audit).lint38,format45,test48 秒main の run には review がないので,比べるのはツールの job の時間.ツールの job は並列で,最長の
audit(56 秒)が全体の待ち時間を決める.これは変更前の 36〜74 秒の範囲に収まっている.ただし,変更前の job ごとの時間は取っていないので,job 単位の前後比較はしていない.検証
nix flake check --all-systems --no-build --option allow-import-from-derivation falseが通るcargo clippy,cargo fmt --check,cargo test,cargo machete,cargo deny check bans licenses sourcesが成功Refs furedea/reusable-workflows#23
🤖 Generated with Claude Code