Skip to content

ci: run the Rust tools from the flake dev shell - #17

Merged
furedea merged 3 commits into
mainfrom
ci/23-dev-shell
Nov 9, 2026
Merged

furedea merged 3 commits into
mainfrom
ci/23-dev-shell

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

概要

CI の Rust のツールを,flake の devShell から動かす形にする.手元と CI で同じ版になり,flake.lock で中身が固定される.

変更

項目 内容
devShell aarch64-darwin に加えて x86_64-linux でも使えるようにした(genAttrs).ツールは元から揃っていた
ci.yml lint,format,test,audit から setup-rust-toolchain,cargo-deny-action,cargo-machete を削除
各 job checkout → nix-setup(v1.3.0,SHA 固定)→ run.defaults.run.shell は nix develop --command bash -eo pipefail {0}(job ごと.all-green は nix なしで動かすため)
不変 job 名(必須チェック)と all-green の needs

CI の時間

全体の待ち時間
変更前(main 直近 5 回) 36〜74 秒(38,74,73,52,36)
変更後(この PR の run) ツールの job は最長 56 秒(audit).lint 38,format 45,test 48 秒

main の run には review がないので,比べるのはツールの job の時間.ツールの job は並列で,最長の audit(56 秒)が全体の待ち時間を決める.これは変更前の 36〜74 秒の範囲に収まっている.ただし,変更前の job ごとの時間は取っていないので,job 単位の前後比較はしていない.

検証

  • nix flake check --all-systems --no-build --option allow-import-from-derivation false が通る
  • Linux の devShell は cache から取得できる(126 パス,約 280 MiB,ソースビルドなし)
  • devShell 内で cargo clippy,cargo fmt --check,cargo test,cargo machete,cargo deny check bans licenses sources が成功

Refs furedea/reusable-workflows#23

🤖 Generated with Claude Code

furedea and others added 3 commits November 9, 2026 21:38
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 9, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T12:59:26.438076Z b469451 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

Review summary

No findings. I didn't post any inline comments.

What I checked:

  • CI jobs: lint, format, test and audit now run each step through nix develop --command bash -eo pipefail {0}, with nix-setup before them. all-green keeps the top-level bash default, and job names and needs are the same, so the required checks don't change.
  • Toolchain: nixpkgs 26.05 ships a rustc new enough for edition = "2024". Removing setup-rust-toolchain doesn't change RUSTFLAGS, since it was already set to rustflags: "". clippy -D warnings is still passed explicitly.
  • cargo-deny: cargo deny check runs every check, advisories included, which matches what the action did. The [advisories] section in deny.toml still applies. (The PR verification lists only bans licenses sources, so advisories will first run for real in CI.)
  • flake.nix: the genAttrs refactor keeps the aarch64-darwin shell as it was and adds x86_64-linux. lefthook from unstable is still picked per system.

Blocking findings: 0

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: b469451d48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@furedea
furedea merged commit e62e7f5 into main Nov 9, 2026
18 checks passed
@furedea
furedea deleted the ci/23-dev-shell branch November 9, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant