Skip to content

ci: use the shared lint and nix workflows - #16

Merged
furedea merged 1 commit into
mainfrom
ci/shared-workflows-follow-up
Nov 8, 2026
Merged

furedea merged 1 commit into
mainfrom
ci/shared-workflows-follow-up

Conversation

@furedea

@furedea furedea commented Nov 8, 2026

Copy link
Copy Markdown
Owner

GitHub Actions の lint(actionlint,zizmor),dependency review,nix lint,flake check を,furedea/reusable-workflows v1.1.0 の共有 workflow から呼ぶように変えます.呼んだジョブは all-green の needs に入るので,失敗するとマージできません.CodeQL は workflow をやめ,GitHub の default setup に移します.

項目 今 変更後
共有 workflow の固定 @<sha> # main(main が進むと zizmor の ref-version-mismatch で落ちる) @<sha> # v1.1.0
actionlint / zizmor gha_lint.yml(workflow を変えた PR だけ) ci.yml から gha-lint.yml を呼ぶ(全 PR,all-green に入る)
dependency review dependency_review.yml(all-green の外),または無し ci.yml から dependency-review.yml を呼ぶ.非公開 repo と PR 以外では飛ばして成功扱い
nix lint ci.yml に直接書いたジョブ nix-lint.yml を呼ぶ
flake check repo ごと(無い repo もある) nix-check.yml を呼ぶ(nix flake check -L と全 system の評価)
CodeQL codeql.yml(非公開 repo でも動いて失敗する) codeql.yml を消す.public repo は default setup をオンにする(本人が設定)
claude-review / codex-review # main の古い SHA # v1.1.0
  • 呼んだ共有ジョブがすべて成功する
  • all-green が green になる
出典

🤖 Generated with Claude Code

Pin every furedea/reusable-workflows call to v1.1.0. Delete
codeql.yml: CodeQL moves to GitHub's default setup, which private
repositories without code scanning never run.

Refs furedea/reusable-workflows#6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 8, 2026 16:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T16:20:24.354137Z 9091db1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@furedea

furedea commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

No blocking findings (P0: 0, P1: 0).

  • All six reusable-workflow calls are moved to ca7c5f2… with a # v1.1.0 comment. Every called job is still listed in all-green.needs, and the per-job permissions are unchanged.
  • Deleting codeql.yml takes CodeQL scanning (rust and actions) off this repo until someone turns on default setup in the repository settings. Please do that right after merging.
  • Not verified in this review: that ca7c5f2 is the v1.1.0 tag in furedea/reusable-workflows, and that v1.1.0 doesn't need more caller permissions than v1.0.0. I couldn't reach that repo from this environment. The all-green check on this PR will confirm both.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 9091db18e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@furedea
furedea merged commit fd0a433 into main Nov 8, 2026
15 checks passed
@furedea
furedea deleted the ci/shared-workflows-follow-up branch November 8, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants