Repository navigation
ci: use the shared lint and nix workflows - #16
Merged
Merged
Conversation
Pin every furedea/reusable-workflows call to v1.1.0. Delete codeql.yml: CodeQL moves to GitHub's default setup, which private repositories without code scanning never run. Refs furedea/reusable-workflows#6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
No blocking findings (P0: 0, P1: 0).
|
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions の lint(actionlint,zizmor),dependency review,nix lint,flake check を,furedea/reusable-workflows v1.1.0 の共有 workflow から呼ぶように変えます.呼んだジョブは
all-greenのneedsに入るので,失敗するとマージできません.CodeQL は workflow をやめ,GitHub の default setup に移します.@<sha> # main(main が進むと zizmor のref-version-mismatchで落ちる)@<sha> # v1.1.0gha_lint.yml(workflow を変えた PR だけ)ci.ymlからgha-lint.ymlを呼ぶ(全 PR,all-greenに入る)dependency_review.yml(all-greenの外),または無しci.ymlからdependency-review.ymlを呼ぶ.非公開 repo と PR 以外では飛ばして成功扱いci.ymlに直接書いたジョブnix-lint.ymlを呼ぶnix-check.ymlを呼ぶ(nix flake check -Lと全 system の評価)codeql.yml(非公開 repo でも動いて失敗する)codeql.ymlを消す.public repo は default setup をオンにする(本人が設定)# mainの古い SHA# v1.1.0all-greenが green になる出典
🤖 Generated with Claude Code