Repository navigation
ci: use the shared lint and nix workflows - #15
Conversation
Call gha-lint, dependency-review, nix-lint and nix-check from furedea/reusable-workflows v1.0.0 and require them in all-green. Remove the per-repository GitHub Actions lint and dependency review workflows, move flake checks to the shared nix-check, skip CodeQL on private repositories, and pin the review workflows to the same release. Refs furedea/reusable-workflows#6 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
|
||
| jobs: | ||
| analyze: | ||
| if: ${{ !github.event.repository.private }} |
There was a problem hiding this comment.
P2 — I don't think this guard works for the weekly schedule trigger. A schedule event payload doesn't include repository, so github.event.repository.private is null and !null is true. In a private repo made from this template, the PR and push runs get skipped as intended, but the Monday cron run would still start CodeQL. It would then fail at upload because code scanning isn't available on private repos without GHAS.
One possible fix is to also skip scheduled runs on private repos with a check that doesn't depend on the event payload. For example, gate on a repo variable, or use github.event_name != 'schedule' && !github.event.repository.private. That second option also drops the cron on public repos, so pick whichever fits.
Review summaryBlocking findings (P0/P1): 0
The rest of the diff looks fine. The four new jobs are added to I couldn't open the called workflows in
🤖 Generated with Claude Code |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
GitHub Actions の lint(actionlint,zizmor),dependency review,nix lint,flake check を,furedea/reusable-workflows v1.0.0 の共有 workflow から呼ぶように変えます.4 つとも
all-greenのneedsに入るので,失敗するとマージできません.@<sha> # main(main が進むと zizmor のref-version-mismatchで落ちる)@<sha> # v1.0.0gha_lint.yml(workflow を変えた PR だけ)ci.ymlからgha-lint.ymlを呼ぶ(全 PR,all-greenに入る)dependency_review.yml(all-greenの外),または無しci.ymlからdependency-review.ymlを呼ぶ.非公開 repo と PR 以外では飛ばして成功扱いci.ymlに直接書いたジョブnix-lint.ymlを呼ぶnix-check.ymlを呼ぶ(nix flake check -Lと全 system の評価)# mainの古い SHA# v1.0.0gha-lint / …,dependency-review / …,nix-lint / nix-lint,nix-check / nix-checkが成功するall-greenが green になる出典
.github/dependency_review_config.ymlは共有 workflow の既定値(fail-on-severity: high)と同じだった🤖 Generated with Claude Code