Skip to content

ci: add the codex review job - #14

Merged
furedea merged 1 commit into
mainfrom
ci/add-the-codex-review-job
Nov 6, 2026
Merged

furedea merged 1 commit into
mainfrom
ci/add-the-codex-review-job

Conversation

@furedea

@furedea furedea commented Nov 6, 2026

Copy link
Copy Markdown
Owner

全 PR を Codex がレビューする共有 workflow(furedea/reusable-workflows の codex-review.yml)を ci.yml から呼び,all-green の needs に加えます.
CI がオーナーの token で @codex review を投稿し,HEAD の commit に未解決の指摘があるか,Codex が失敗するか,20 分以内に結果がないと all-green が赤になります.PR 以外のイベント,フォークからの PR,furedea-agent 以外の bot の PR では飛ばし,成功として扱います.

  • codex-review / Decide whether to review と codex-review / Codex review が成功する
  • all-green が green になる
出典

🤖 Generated with Claude Code

Call the shared codex-review workflow from furedea/reusable-workflows
and require it in all-green.

Refs furedea/reusable-workflows#7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 6, 2026 16:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@furedea

furedea commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T16:43:15.203457Z 5f69f2c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Review summary

I found no blocking issues. The change adds one job to .github/workflows/ci.yml that calls furedea/reusable-workflows/.github/workflows/codex-review.yml, pinned to a commit SHA, and adds that job to all-green.needs.

  • It follows the same pattern as the existing claude-review job: the SHA is pinned, the secret is passed explicitly, and the workflow-level permissions: {} default is unchanged.
  • permissions: {} on the calling job means the called workflow gets no GITHUB_TOKEN scopes. That is fine as long as the called workflow uses only codex_review_token for GitHub API calls. I couldn't read the called workflow from this environment, so I haven't checked this. The PR's own checklist run (Decide whether to review / Codex review succeeding) will confirm it.
  • all-green treats skipped as a failure. Push, fork and other-bot events stay green only if the called workflow keeps its "Decide" job running and skips only the review job, which the PR description says it does.

No P0 or P1 findings.

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 5f69f2cd9e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@furedea
furedea merged commit fe68bdb into main Nov 6, 2026
16 checks passed
@furedea
furedea deleted the ci/add-the-codex-review-job branch November 6, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants