Skip to content

build(ruff): ignore PLR0917 - #23

Merged
furedea merged 1 commit into
mainfrom
build/ignore-plr0917
Nov 10, 2026
Merged

furedea merged 1 commit into
mainfrom
build/ignore-plr0917

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

概要

グローバルの [tool.ruff.lint] ignore に PLR0917 を追加します.

理由

  • PLR0917 は ruff 0.16 で stable になります.agent-config 0.17.0 と dotfiles 0.17.3 は,PLR プレフィックス経由で既にこのルールを有効にしています.
  • このテンプレートは ruff 0.15.11 に固定しており,そこでは PLR0917 はまだ preview です.そのため現状では無効ですが,ruff の pin を上げた時点で有効になります.
  • PLR0913 (max-args = 3) が引数の総数を既に制限しており,位置引数の数もその範囲に収まります.そのため PLR0917 は追加の情報を与えません.
  • 全 Python リポジトリで同じ ignore を書きます.

範囲外

  • ruff の bump は行いません.

検証

  • ruff check: All checks passed
  • ruff format --check: 2 files already formatted

Refs furedea/agent-config#74

🤖 Generated with Claude Code

PLR0913 (max-args = 3) already caps the total argument count, which
bounds the positional count, so PLR0917 adds no signal.

Refs furedea/agent-config#74

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 10, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T11:13:04.667774Z
We couldn’t complete this review. Comment @codex review to try again.
ca75e53 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

Copy link
Copy Markdown

Review summary

No findings.

This PR adds PLR0917 to the global [tool.ruff.lint] ignore list in pyproject.toml. I checked the reasoning against the config: [tool.ruff.lint.pylint] max-args = 3 is set, so PLR0913 already limits the total argument count to below PLR0917's default max-positional-args of 5. That makes the ignore redundant but harmless. The config has explicit-preview-rules = true, so the rule is currently off under ruff 0.15.11. The ignore only matters once the pin is bumped. No code behaviour changes, so no tests are needed.

Blocking findings (P0/P1): 0

@furedea
furedea merged commit cb25d58 into main Nov 10, 2026
16 of 18 checks passed
@furedea
furedea deleted the build/ignore-plr0917 branch November 10, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant