Repository navigation
build(ruff): drop the inactive CPY select - #22
Conversation
CPY001 is preview-only, fires on the template's own src/main.py, and personal repositories need no copyright header. PLR0917 is a preview rule, so under explicit-preview-rules the PLR prefix does not enable it. Select it explicitly and ignore it in tests only: pytest passes fixtures and parametrize values by name, so positional-order mistakes cannot happen there. Refs furedea/agent-config#74 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "INP", | ||
| "C901", | ||
| "PLR1702", | ||
| "PLR0917", |
There was a problem hiding this comment.
P3: In src, enabling PLR0917 has almost no effect with the current settings. PLR0917 uses max-positional-args, which isn't set here, so it defaults to 5 and only fires at 6 or more positional args. But [tool.ruff.lint.pylint] max-args = 3 already makes PLR0913 fire at 4 or more args. So every function PLR0917 flags is already flagged by PLR0913, and you just get a second diagnostic. Your probe only showed PLR0917 on its own because tests/** also ignores PLR0913. If you want this rule to catch something extra, set max-positional-args below max-args (e.g. max-positional-args = 2, which forces keyword-only args past the second parameter). Otherwise it's fine as a harmless guard in case max-args is raised later.
There was a problem hiding this comment.
Addressed in 834abd0: PLR0917 is removed (select and tests ignore), since with max-args = 3 it is fully covered by PLR0913. The PR now only drops the inactive CPY select.
Review summaryNo blocking issues. This PR only changes the ruff config.
No tests are needed for a lint-config change. Blocking findings (P0/P1): 0 |
PLR0917 is not used. With max-args = 3 it is fully covered by PLR0913: the positional count never exceeds the total count, so it can never add a finding. Revert the explicit select and the tests ignore added in the previous commit; the CPY removal stays. Refs furedea/agent-config#74 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
furedea-agent
Bot
changed the title
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Review summaryNo findings. The diff removes Blocking findings (P0/P1): 0 |
概要
リンター設定を各リポジトリで揃えるための template-python 側の変更です．
CPYを select から削除：CPY は preview 専用のため，explicit-preview-rules下ではCPYの select は何も有効にしない死んだ項目です．個人リポジトリに著作権ヘッダも不要です．PLR0917 を使わない理由
PLR0917（位置引数の数）は使いません．
max-args = 3の下では，位置引数の数は全引数の数を超えないため，PLR0913（引数の数）で常に先に検出されます．PLR0917 が新たに検出するものは存在しません（max-positional-argsは未設定で，ruff がmax-argsを継承するため上限も同じ 3 です）．explicit-preview-rules下では PLR0917 は有効になっておらず，この PR でも有効にしません．途中で追加した明示 select とtests/**の ignore は，このブランチの後続コミットで取り除いています．検証
ruff check ./ruff format --check .: 全て passRefs furedea/agent-config#74
🤖 Generated with Claude Code