Skip to content

ci: add the claude review job - #15

Merged
furedea merged 1 commit into
mainfrom
ci/add-the-claude-review-job
Nov 6, 2026
Merged

furedea merged 1 commit into
mainfrom
ci/add-the-claude-review-job

Conversation

@furedea

@furedea furedea commented Nov 6, 2026

Copy link
Copy Markdown
Owner

全 PR を Claude がレビューする共有 workflow(furedea/reusable-workflows の claude-review.yml)を ci.yml から呼び,all-green の needs に加えます.
P0/P1 の指摘があると all-green が赤になります.PR 以外のイベント,フォークからの PR,furedea-agent 以外の bot の PR ではレビューを飛ばし,成功として扱います.

  • claude-review / Decide whether to review と claude-review / Claude review が成功する
  • all-green が green になる
出典

🤖 Generated with Claude Code

Call the shared claude-review workflow from furedea/reusable-workflows
and require it in all-green.

Refs furedea/agent-config#78

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 6, 2026 12:14

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Claude review summary: I found no blocking issues in this change.

The new claude-review job calls a reusable workflow pinned to a commit SHA. It grants only contents: read and pull-requests: write, and passes the one secret it needs. It is now listed in all-green.needs. One thing to watch: all-green fails when any prerequisite is skipped. That is only safe if the reusable workflow reports success when it skips the review, which the description says it does (pushes to main, forks, and other bots' PRs). I couldn't read furedea/reusable-workflows@fc0cba9 from here, so I haven't checked that claim, or whether the called workflow needs more permissions such as id-token: write. The first CI run on this PR will settle both questions.

@furedea
furedea merged commit 5540b40 into main Nov 6, 2026
14 checks passed
@furedea
furedea deleted the ci/add-the-claude-review-job branch November 6, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants