Skip to content

build(lint): drop vague directory names from ls-lint - #10

Merged
furedea merged 1 commit into
mainfrom
build/drop-vague-dir-names-from-ls-lint
Nov 14, 2026
Merged

furedea merged 1 commit into
mainfrom
build/drop-vague-dir-names-from-ls-lint

Conversation

@furedea-agent

@furedea-agent furedea-agent Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

概要

.ls-lint.yml から pkg,util,common の禁止エントリとそのコメント行を削除しました.

理由

名前の語彙チェックは agent-config の ast-grep ルールへ移し,ls-lint は名前の形(shape)のみを検査する方針に決まりました.

ローカルで ls_lint を実行し,違反がないことを確認しています.

Refs furedea/agent-config#74

🤖 Generated with Claude Code

Name vocabulary checks move to agent-config ast-grep rules, so ls-lint keeps only name shape.

Refs furedea/agent-config#74

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@furedea

furedea commented Nov 14, 2026

Copy link
Copy Markdown
Owner

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T11:48:32.529399Z 87a72e7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Review summary: no findings.

This PR only removes the **/{pkg,util,common} ban from .ls-lint.yml. The other rules (directory and file name shapes, the internal identifier regex, ignores) are unchanged, and the YAML is still valid. Code and tests are unaffected.

One thing to know: after this merge, nothing in this repo's CI or lefthook checks for these names. That job now belongs to the ast-grep rule in agent-config (furedea/agent-config#74). This PR states that move as intended, so it isn't a defect.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 87a72e7a4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@furedea
furedea merged commit b47607b into main Nov 14, 2026
18 checks passed
@furedea
furedea deleted the build/drop-vague-dir-names-from-ls-lint branch November 14, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant