Repository navigation
build(lint): set no-unused-vars ignoreRestSiblings - #111
Merged
Merged
Conversation
Allow the key-omitting pattern const { password, ...safeUser } = user.
Every TypeScript repo now configures the rule the same way.
Refs furedea/agent-config#74
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Owner
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review summary No findings. The one-line change adds
Blocking findings: 0 |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
furedea-com | d39c91f | Commit Preview URL Branch Preview URL |
Nov 10 2026, 05:03 PM |
furedea
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
.oxlintrc.jsonのrulesに"no-unused-vars": ["warn", { "ignoreRestSiblings": true }]を追加します．effort-or-luckと同じ 1 行の形で，同じ位置（max-paramsの次，typescript/*の前）に置きます．理由
no-unused-varsは oxlint の correctness カテゴリで既定で有効です．ignoreRestSiblingsだけでした．これを有効にすると，const { password, ...safeUser } = user;のようなキーを除外する書き方が警告になりません．effort-or-luckはすでにこの設定を持ち，テンプレートにも並行する PR で入ります．すべての TS リポジトリで同じ書き方にそろえます．削除した ignore
なし．
新規ルールの違反
なし（
pnpm run lint --deny-warningsは 0 warnings / 0 errors）．検証
pnpm run format:check，pnpm run lint，pnpm run test（128 件），pnpm run knipは dev shell で成功．pnpm run typecheckは dev shell の Node が 22.23.3（Astro の要求は 22.23.4 以上）のためローカルでは実行できず，CI で確認します．Refs furedea/agent-config#74
🤖 Generated with Claude Code