Repository navigation
ci: rename external links workflow to kebab-case - #109
Conversation
GitHub Actions workflow files conventionally use kebab-case. Rename external_links.yml to external-links.yml, update the workflow specification test that reads it, and require kebab-case for .yml files in ls-lint. The workflow and job names are unchanged, so the required all-green check is unaffected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
furedea-com | bb5cc6d | Commit Preview URL Branch Preview URL |
Nov 09 2026, 08:09 AM |
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .dir: regex:\.?[a-z0-9]+(-[a-z0-9]+)* | ||
| .md: regex:[a-z0-9]*([._][a-z0-9]+)* | regex:(README|CONTRIBUTING|CHANGELOG|AGENTS|CLAUDE|SKILL|CONTENT_LICENSE) | ||
| .yaml: regex:[a-z0-9]*([._][a-z0-9]+)* | regex:pnpm-(lock|workspace) | ||
| .yml: regex:[a-z0-9]+(-[a-z0-9]+)* |
There was a problem hiding this comment.
P2: The new .yml rule now applies to every *.yml file in the repo, not just workflow files. That includes the dot-prefixed .ls-lint.yml and .commitlintrc.yml. The regex [a-z0-9]+(-[a-z0-9]+)* can't match a leading dot. If ls-lint picks .yml as the extension for those files, it checks the names .ls-lint and .commitlintrc and the ls_lint pre-commit hook fails. Before this change, .yml files fell through to .*, whose [._] prefix allows a leading dot, and .dir already allows one with \.?. I couldn't run ls-lint here to confirm, so please run ls_lint locally. If it fails, a fix that keeps kebab-case:
| .yml: regex:[a-z0-9]+(-[a-z0-9]+)* | |
| .yml: regex:\.?[a-z0-9]+(-[a-z0-9]+)* |
There was a problem hiding this comment.
Refuting with a local run: ls_lint passes on this commit (bb5cc6d), including the dot-prefixed .ls-lint.yml and .commitlintrc.yml; the lefthook pre-commit ls-lint job also passed when the commit was created. ls-lint takes the extension from the last dot after the leading dot, so a dot-prefixed file is checked as ls-lint / commitlintrc, which match the kebab-case regex. Before this change the same job failed on external-links.yml, so the rule is exercised. No change needed.
|
Review summary The workflow rename and the updated test path are correct. The workflow One finding:
No blocking issues. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
概要
GitHub Actions のワークフローファイル名は kebab-case が慣例のため，
external_links.ymlをexternal-links.ymlにリネームします．変更内容
.github/workflows/external_links.yml→external-links.ymlsrc/external_links_workflow.test.tsの参照パスを更新.ls-lint.ymlに.yml用の kebab-case ルールを追加影響
name:と job 名は変更していないため，required status check（all-green）に影響しません．🤖 Generated with Claude Code