Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions nix/home/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,26 @@ in
refetchIntervalMinutes = 5;
};
smartFilteringAtLaunch = true;
issuesSections = [
{
title = "Open";
filters = "is:open -author:app/renovate";
}
{
title = "All repos";
filters = "is:open user:furedea -author:app/renovate";
}
Comment on lines +460 to +463

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: With smartFilteringAtLaunch = true, gh-dash scopes every section that has no repo: in its filter to the current repo at launch. That includes this "All repos" section (and the matching one under prsSections). Started inside a repo, "All repos" will probably show the same results as "Open" until you press t on that section. GitHub's handling of user: combined with an added repo: is also unclear. The PR description lists only the Open sections, so these extra sections look unplanned. Either remove them, or check that they actually show cross-repo results when gh-dash starts inside a repo.

];
prsSections = [
{
title = "Open";
filters = "is:open";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] These sections rely only on smartFilteringAtLaunch to add repo:. gh-dash adds that only when it starts inside a git repo that has a GitHub remote. Started anywhere else (for example ~), is:open and is:open -author:app/renovate run as GitHub-wide searches and show unrelated public issues and PRs. The old defaults were scoped to @me, so that case used to give useful results. To keep it useful, add a second section scoped to you, like is:open user:furedea (or org:/involves:). Another option is to note that gh-dash should only be launched from inside a repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the latest commit: each view now has a second section, All repos (is:open user:furedea, plus -author:app/renovate for issues). The first Open sections stay unscoped so smart filtering narrows them inside a repo. Outside a repo, All repos gives a cross-repo list limited to the user's repositories.

}
{
title = "All repos";
filters = "is:open user:furedea";
}
];
};
};

Expand Down
Loading