Skip to content

codebase conventions - #130

Open
corresp0nd wants to merge 3 commits into
mainfrom
codebaseconventions
Open

codebase conventions#130
corresp0nd wants to merge 3 commits into
mainfrom
codebaseconventions

Conversation

@corresp0nd

Copy link
Copy Markdown
Collaborator

list of what we expect from prs / code in general & explanations why

@Komonighub Komonighub left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sleepyyapril sleepyyapril left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meow

Comment thread src/contributing/codebase-conventions.md Outdated

## Use the `Fu` prefix to replace entities or locale

There are times when entities change so drastically from their upstream version that it is easier to create new entities entirely. When we do this, we add the `Fu` prefix to the new entity id and create it in our namespace. You would then replace all of the usages of the old entity with the new id.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe. no review. just funny. Fu. Hehe.

Comment thread src/contributing/codebase-conventions.md Outdated
Comment thread src/contributing/codebase-conventions.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants