perf(dotnet): align build/test MSBuild property sets to avoid duplicate compile - #986
perf(dotnet): align build/test MSBuild property sets to avoid duplicate compile#986dnyw4l3n13 wants to merge 2 commits into
Conversation
Prompt: Work on issue #870 in funfair-tech/funfair-server-template.
|
Simplify clean - advancing to code review. Reviewed the diff across reuse/simplification/efficiency/altitude; no changes applied. Two non-blocking observations noted for the next phase to re-cover if relevant: the |
|
Code review clean - advancing to security review |
|
Security review clean, advancing to coverage check |
|
Coverage ratchet passed - advancing to Human Review |
|
PR marked ready for review and auto-merge (merge commit) enabled. All AI review phases (Simplify, Code Review, Security Review, Coverage) passed clean; no outstanding comments or CI failures found. Ready for human review. |
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
Summary
The "Dotnet: Build (Non-Release)" step and the "Dotnet: Test" step in
.github/actions/dotnet/action.ymlpass different MSBuild global-property sets. Different global properties invalidate MSBuild'sCoreCompileincremental-build fingerprint, sodotnet testends up recompiling the solution instead of reusing the prior build's output.This PR aligns the two property sets so the solution compiles once per CI run instead of twice.
See the Implementation Plan on the linked issue for the root-cause analysis and approach.
This is currently a placeholder commit (
.deleteme.now) to open the draft PR; the actual property-set alignment lands in a follow-up commit.Closes #870