Skip to content

perf(dotnet): align build/test MSBuild property sets to avoid duplicate compile - #986

Open
dnyw4l3n13 wants to merge 2 commits into
mainfrom
perf/870-align-build-test-msbuild-properties
Open

perf(dotnet): align build/test MSBuild property sets to avoid duplicate compile#986
dnyw4l3n13 wants to merge 2 commits into
mainfrom
perf/870-align-build-test-msbuild-properties

Conversation

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator

Summary

The "Dotnet: Build (Non-Release)" step and the "Dotnet: Test" step in .github/actions/dotnet/action.yml pass different MSBuild global-property sets. Different global properties invalidate MSBuild's CoreCompile incremental-build fingerprint, so dotnet test ends up recompiling the solution instead of reusing the prior build's output.

This PR aligns the two property sets so the solution compiles once per CI run instead of twice.

See the Implementation Plan on the linked issue for the root-cause analysis and approach.

This is currently a placeholder commit (.deleteme.now) to open the draft PR; the actual property-set alignment lands in a follow-up commit.

Closes #870

Prompt: Work on issue #870 in funfair-tech/funfair-server-template.
@dnyw4l3n13 dnyw4l3n13 self-assigned this Sep 11, 2026
@dnyw4l3n13 dnyw4l3n13 added github-actions Github actions workflow files AI-Work Work for an AI Agent Low Low Priority labels Sep 11, 2026
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Simplify clean - advancing to code review. Reviewed the diff across reuse/simplification/efficiency/altitude; no changes applied. Two non-blocking observations noted for the next phase to re-cover if relevant: the -p:Optimize=true explicit flag is technically redundant under --configuration Release (pre-existing convention, out of scope for this diff), and there is no shared-props mechanism enforcing parity between the build/test property lists going forward (architectural, out of scope for this fix).

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Code review clean - advancing to security review

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Security review clean, advancing to coverage check

@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

Coverage ratchet passed - advancing to Human Review

@dnyw4l3n13
dnyw4l3n13 marked this pull request as ready for review September 11, 2026 21:46
@dnyw4l3n13
dnyw4l3n13 requested a review from a team as a code owner September 11, 2026 21:46
@dnyw4l3n13

Copy link
Copy Markdown
Collaborator Author

PR marked ready for review and auto-merge (merge commit) enabled. All AI review phases (Simplify, Code Review, Security Review, Coverage) passed clean; no outstanding comments or CI failures found. Ready for human review.

@credfeto

Copy link
Copy Markdown
Member

Super-linter summary

Language Validation result
YAML Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Work Work for an AI Agent github-actions Github actions workflow files Low Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(dotnet): test step property mismatch forces a full rebuild after the build step

2 participants