fix(pr-lint): remove unreachable trufflehog scan-results step

[dnyw4l3n13]

Summary

The trufflesecurity/trufflehog step in does-not-contain-secrets has no continue-on-error: true, so a failure already stops the job immediately. The subsequent Scan Results Status step (if: steps.trufflehog.outcome == 'failure', run: exit 1) can never execute and is dead code. This removes it.

No CHANGELOG.md entry is included: this repository name ends in -template, and the repo's pre-commit changelog lint enforces that CHANGELOG.md stays blank for template repos.

How Has This Been Tested

• Workflow YAML change only; no unit/integration tests apply.
• Verified via repo's actionlint/yamllint pre-commit hooks.

Types of changes

• Removed no-longer used code

Checklist

• No user-controlled or step-output value is string-interpolated directly into a run:/script: body.

Closes #871

[dnyw4l3n13]

Implemented per the approved plan: removed the unreachable Scan Results Status step from the does-not-contain-secrets job in pr-lint.yml, since the preceding trufflehog step has no continue-on-error and already fails the job on its own. No CHANGELOG.md entry was added - this repo's pre-commit changelog lint requires CHANGELOG.md to stay blank for -template repositories. Draft PR opened; the pull-request workflow will take it from here.

[dnyw4l3n13]

Simplify clean - advancing to code review

[dnyw4l3n13]

Code review clean - advancing to security review

[dnyw4l3n13]

Security review clean, advancing to coverage check

[dnyw4l3n13]

Coverage ratchet passed - advancing to Human Review

[dnyw4l3n13]

PR was still a draft, so auto-merge could not be enabled directly; marked it ready for review instead. All automated phases (development, simplify, code review, security review, coverage) have passed - ready for human review.

[credfeto]

Super-linter summary

Language	Validation result
GITHUB_ACTIONS	Pass ✅
YAML	Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

[dnyw4l3n13]

Auto-merge enabled - PR is ready and will merge once required approvals/checks are satisfied.