Standardize existing QA and remove CodeRabbit

.changeset/qa-workflow-standardization.md

@@ -0,0 +1,2 @@
+---
+---

.coderabbit.yaml

@@ -0,0 +1,12 @@
+# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
+inheritance: false
+reviews:
+  request_changes_workflow: false
+  review_status: false
+  review_progress: false
+  commit_status: false
+  auto_review:
+    enabled: false
+    auto_incremental_review: false
+    description_keyword: ""
+    labels: []

.github/workflows/check.yml

@@ -15,4 +15,7 @@ concurrency:
 jobs:
   check:
     name: Check
-    uses: fulldotdev/.github/.github/workflows/check.yml@288d0a18bdcc83e2376c91f557577f0dfe4d1e56
+    uses: fulldotdev/.github/.github/workflows/check.yml@f2895c09a7d688a58f2bacc200c7b18bc07574e7
+    with:
+      runner: blacksmith-4vcpu-ubuntu-2404
+      command: vp run check:source

.github/workflows/ready.yml

@@ -14,19 +14,21 @@ on:
         unlabeled,
       ]
   workflow_run:
-    workflows: [Check, Review event]
+    workflows: [Check]
     types: [completed]
 
 permissions:
+  actions: read
   contents: write
   pull-requests: write
   statuses: write
   checks: read
 
 jobs:
   ready:
-    uses: fulldotdev/.github/.github/workflows/ready.yml@579bcf444a2f964e48ecbeb580b01c921c9f1ea4
+    uses: fulldotdev/.github/.github/workflows/ready.yml@f2895c09a7d688a58f2bacc200c7b18bc07574e7
     with:
+      runner: blacksmith-2vcpu-ubuntu-2404
       netlify-checks: '["netlify/fulldev-sitex/deploy-preview"]'
       merge-app-client-id: ${{ vars.RELEASE_APP_CLIENT_ID }}
     secrets:

CONTRIBUTING.md

@@ -14,7 +14,7 @@ pnpm dev
 Run these before opening a pull request:
 
 ```bash
-pnpm check
+vp run check:source
 pnpm ready
 ```
 

README.md

@@ -13,10 +13,11 @@ packages/sitex/   # @fulldotdev/sitex package source
 ## Scripts
 
 ```bash
-pnpm dev      # run the docs app
-pnpm build    # build all workspace packages/apps
-pnpm check    # format, lint, and typecheck
-pnpm ready    # check and build everything
+pnpm dev             # run the docs app
+pnpm build           # build all workspace packages/apps
+vp run check:build   # typecheck the docs app with the types its build generated
+vp run check:source  # format, lint, and typecheck
+pnpm ready           # check and build everything
 ```
 
 ## Package

apps/docs/package.json

@@ -5,7 +5,8 @@
   "type": "module",
   "scripts": {
     "dev": "vp dev --host 127.0.0.1 --port 4323",
-    "build": "shadcn build && vp build && tsc --noEmit",
+    "build": "shadcn build && vp build",
+    "check:build": "tsc --noEmit",
     "preview": "vp preview --host 127.0.0.1 --port 4323",
     "registry:build": "shadcn build"
   },

netlify.toml

@@ -1,5 +1,5 @@
 [build]
-command = "pnpm build"
+command = "pnpm build && pnpm run check:build"
 publish = "apps/docs/dist"
 
 [build.environment]
@@ -79,7 +79,7 @@ to = "/docs/components/:splat"
 status = 301
 
 [context.production]
-command = "pnpm run check && pnpm build"
+command = "pnpm run check:source && pnpm build && pnpm run check:build"
 
 [[headers]]
 for = "/*"

package.json

@@ -4,11 +4,12 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "ready": "vp check && vp run @fulldotdev/sitex#check && vp run -r build",
+    "ready": "vp run check:source && vp run build && vp run check:build",
     "dev": "vp run docs#dev",
     "build": "vp run -r build",
-    "check": "vp check && vp run @fulldotdev/sitex#check",
-    "format": "vp fmt",
+    "check:build": "vp run docs#check:build",
+    "check:source": "vp check && vp run @fulldotdev/sitex#check",
+    "fix:source": "vp check --fix",
     "preview": "vp run docs#preview",
     "changeset": "changeset",
     "release": "changeset version && pnpm install --lockfile-only && vp fmt",