Repository navigation
Fix portable standard-font previews in .NET 0.1.6 - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unembedded Helvetica, Times and Courier PNG previews currently depend on the machine's fonts and can be blank when no fallback is installed. Pin Fullbleed 2.5.11 in binding 0.1.6 so previews use bundled outline substitutes, while preserving PDF bytes and embedded-font previews. Include the upstream OFL, Adobe and modification/provenance notices in the NuGet archive.
The release gate now checks 52 font cases through ordinary, fixed and both reflow modes across the same twelve packed consumers (.NET 8/9/10 on four RIDs). It also compares hash-pinned public 0.1.5 and the candidate inside a Linux mount namespace with system fonts hidden. All existing inline native previews must now agree across platforms; the previously reviewed 2.5.10 layout hashes are preserved.
Local validation: Rust 1.85 build/fmt/clippy and 3 native tests; managed build/format and 18 tests; isolated Windows NuGet consumer, six base documents, 22 family cases, 54 inline cases and 52 standard-font cases. All 52 PDF byte sequences and all four embedded-font controls match public 0.1.5. Native and independent PDFium specimens visually inspected. Cross-platform and missing-font checks run in CI before release.
Preview substitutes can differ from the original font designs; explicit font registration remains available. These fixture checks make no general conformance or universal font-parity claim.