[codex] Fix factorial work distribution and update for Zig 0.16#2
Closed
mjackson wants to merge 2 commits into
Closed
[codex] Fix factorial work distribution and update for Zig 0.16#2mjackson wants to merge 2 commits into
mjackson wants to merge 2 commits into
Conversation
Author
|
Superseded by #3 from the correctly prefixed branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR fixes a real bug in the factorial implementation and updates the project to build cleanly with Zig 0.16.
Why it changed
The repo no longer built with the current Zig toolchain because both the build API and several stdlib APIs had changed.
While updating the code, I also found a separate bug in
factorial.zig: the work distribution logic returned a slice backed by stack memory and also assumed a maximum of 8 threads even though the thread count is user-controlled.Impact
zig buildnow succeeds on Zig 0.16zig build testnow succeeds on Zig 0.16Root cause
root_source_file,std.io.getStdOut,std.fs.cwd, and older process/random helpers.Validation
zig buildzig build test