feat: add stock ownership etf_holdings REST endpoint#19
Open
kevinypfan wants to merge 4 commits into
Open
Conversation
Add client method for GET /v1.0/stock/ownership/etf-holdings/{symbol},
exposing daily ETF component holdings via stock.ownership.etf_holdings()
with optional from/to/sort/code query params. Since `from` is a reserved
Python keyword, callers pass it as `from_` (mapped to `from` in the query
string). Includes the ownership module, client property, tests, and README
usage example.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Drop the bespoke `from_` -> `from` remapping; callers pass `from` via
dict unpacking (`**{'from': ...}`) like every other endpoint in the SDK,
keeping the API consistent.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Other endpoints aren't individually listed in the README; keep it consistent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Python counterpart adding a client method for
GET /v1.0/stock/ownership/etf-holdings/{symbol}(fugle-realtime issue #622). Client-side only.API
fromis a Python keyword, so callers passfrom_, rebuilt into afromquery key (documented in README + commit).Changes
fugle_marketdata/rest/stock/ownership.py(Ownership(BaseRest)withetf_holdings).ownershipproperty on the stock REST client.tests/test_http_client.py(use a properly-mocked response). README usage example.🤖 Generated with Claude Code