Repository navigation
fix: resolve all 11 lint warnings across packages and examples - #77
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
size-limit report 📦
|
…n configuration example
gabrielvfonseca
force-pushed
the
fix/lint-warnings
branch
from
November 12, 2026 18:42
00edc8f to
efc591f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves all 11
ultracite(Biome) warnings sopnpm lintreports zero findings. Each change is an atomic commit:style(sdk): drop unnecessary constructor from kuzu test fakenoUselessConstructor—FakeConnectionconstructor only took an unused argstyle(examples): replace non-null assertions with optional chaining in configuration examplenoNonNullAssertion—config.output!→config.output?(values are already??-guarded at construction)style(examples): remove unused relation import from crud schemanoUnusedImports—relationimported but never usedstyle(examples): stop assigning unused create results in relations examplenoUnusedVariables—alice/'bob/carol/postwere never read; thecreate()` calls are the point, so drop the assignmentsstyle(examples): remove unused updateSchema and import in zod examplenoUnusedVariables+ the now-unusedtoUpdateSchemaimportstyle(examples): mark createDriver import as intentional in multi-driver examplenoUnusedVariables— the dynamicimport('@graph-kit/sdk/driver')exists to prove the factory entry point resolves; addedvoid createDriverwith a comment instead of deleting the live checkWhy
The pre-commit hook (
pnpm lint && pnpm test:root) gates every commit. Warnings don't fail the hook today, but they're noise that masks real problems and they block a stricter zero-warning policy later.Verification
pnpm lint→ 0 warnings (was 11)pnpm build→ passes--no-verify)