Skip to content

fix: resolve all 11 lint warnings across packages and examples - #77

Merged
gabrielvfonseca merged 6 commits into
mainfrom
fix/lint-warnings
Nov 12, 2026
Merged

gabrielvfonseca merged 6 commits into
mainfrom
fix/lint-warnings

Conversation

@gabrielvfonseca

Copy link
Copy Markdown
Collaborator

What

Resolves all 11 ultracite (Biome) warnings so pnpm lint reports zero findings. Each change is an atomic commit:

Commit Warning(s)
style(sdk): drop unnecessary constructor from kuzu test fake noUselessConstructor — FakeConnection constructor only took an unused arg
style(examples): replace non-null assertions with optional chaining in configuration example 4× noNonNullAssertion — config.output! → config.output? (values are already ?? -guarded at construction)
style(examples): remove unused relation import from crud schema noUnusedImports — relation imported but never used
style(examples): stop assigning unused create results in relations example 4× noUnusedVariables — alice/'bob/carol/postwere never read; thecreate()` calls are the point, so drop the assignments
style(examples): remove unused updateSchema and import in zod example noUnusedVariables + the now-unused toUpdateSchema import
style(examples): mark createDriver import as intentional in multi-driver example noUnusedVariables — the dynamic import('@graph-kit/sdk/driver') exists to prove the factory entry point resolves; added void createDriver with a comment instead of deleting the live check

Why

The pre-commit hook (pnpm lint && pnpm test:root) gates every commit. Warnings don't fail the hook today, but they're noise that masks real problems and they block a stricter zero-warning policy later.

Verification

  • pnpm lint → 0 warnings (was 11)
  • pnpm build → passes
  • Type-check of every touched example package → passes
  • All commits land through the pre-commit hook (no --no-verify)

@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b3fb7edf-c7c2-41ba-ba8a-6d39d1157c7f
Commits

Reviewing files that changed from the base of the PR and between a07748f and efc591f.

Files selected for processing: 6

  • examples/configuration/src/index.ts
  • examples/crud-operations/src/schema.ts
  • examples/multi-driver/src/index.ts
  • examples/relations/src/index.ts
  • examples/zod-validation/src/index.ts
  • packages/sdk/tests/driver-kuzu.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

size-limit report 📦

Path Size
@graph-kit/mcp (import) 1.59 KB (0%)
@graph-kit/mcp (require) 1.68 KB (0%)
@graph-kit/migrate (import) 2.36 KB (0%)
@graph-kit/migrate (require) 2.4 KB (0%)
@graph-kit/sdk (import) 234.5 KB (0%)
@graph-kit/sdk/schema (import) 2.96 KB (0%)
@graph-kit/sdk/client (import) 9.66 KB (0%)
@graph-kit/sdk/errors (import) 6.39 KB (0%)
@graph-kit/sdk/query (import) 7.24 KB (0%)
@graph-kit/sdk/config (import) 1007 B (0%)
@graph-kit/sdk/driver (import) 10.75 KB (0%)
@graph-kit/sdk/driver/neo4j (import) 5.86 KB (0%)
@graph-kit/sdk/driver/memgraph (import) 6.12 KB (0%)
@graph-kit/sdk/driver/kuzu (import) 5.21 KB (0%)
@graph-kit/sdk/driver/falkordb (import) 7.41 KB (0%)
@graph-kit/sdk/migration (import) 10.17 KB (0%)
@graph-kit/sdk/schema/parser (import) 2.39 KB (0%)
@graph-kit/sdk/seed (import) 5.72 KB (0%)
@graph-kit/sdk/observability (import) 6.13 KB (0%)
@graph-kit/sdk/graphql (import) 7.67 KB (0%)
@graph-kit/sdk/visualization (import) 6.18 KB (0%)
@graph-kit/sdk/batch (import) 2.67 KB (0%)
@graph-kit/sdk/auth (import) 12.38 KB (0%)
@graph-kit/sdk/testing (import) 3.3 KB (0%)
@graph-kit/sdk/otel (import) 192.84 KB (0%)
@graph-kit/sdk/benchmark (import) 10.25 KB (0%)
@graph-kit/sdk (require) 235.2 KB (0%)
@graph-kit/testing (import) 2.11 KB (0%)
@graph-kit/testing (require) 2.17 KB (0%)
@graph-kit/zod (import) 866 B (0%)
@graph-kit/zod (require) 906 B (0%)
@graph-kit/cli bin (import) 12.46 KB (0%)
@graph-kit/cli (require) 12.63 KB (0%)

@gabrielvfonseca
gabrielvfonseca merged commit 74d502f into main Nov 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant