Repository navigation
fix(incremental): address all CodeRabbit findings from PR #166 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
d7dcc3f
fix(incremental): address CodeRabbit findings #1-#8, #13 from PR #166
gabrielvfonseca 6abf072
fix(incremental): address CodeRabbit findings #9-#11, #14-#16 from PR…
gabrielvfonseca 134f163
chore(security): ignore RUSTSEC-2026-0543 (chrono unmaintained)
gabrielvfonseca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Serialize initialization across processes.
Two
Store::opencalls can initialize the same fresh store concurrently. The pinned engine checks whethertg.logexists, then writes its header without a lock. Itswrite_fileimplementation opens the file in truncating mode. (raw.githubusercontent.com)Both initializers can observe an absent log. If one completes and records observations before the other resumes, the delayed initializer erases those observations and any baseline.
Add cross-process serialization by store path inside
init_store. Hold it until the child finishes or is terminated and reaped. This also protectsensure_initializedand preserves repeated initialization.