feat: add Iva, Clp, Phone and Region utilities - #23
Merged
Conversation
- Iva: 19% VAT constants and net/gross calculations rounded to the peso - Clp: format and parse Chilean peso amounts ($1.234.567) - Phone: validate, normalize and format Chilean phone numbers (mobile/landline, E.164) - Region: enum with the 16 regions (official names, roman numerals, capitals, north-to-south order) - Laravel: new cl_phone validation rule with en/es translations - README rewritten: feature table, per-class sections, quick-start snippet Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvDYWr2Tx3diCV3NXGrKRX
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughAdds CLP and IVA helpers, Chilean phone normalization and Laravel validation, a 16-region enum, corresponding tests, and substantially refreshed README documentation. ChangesChilean bundle features
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant Request
participant Validator
participant Phone
participant Translation
Request->>Validator: validate cl_phone input
Validator->>Phone: Phone::check(value)
Phone-->>Validator: validation result
Validator->>Translation: resolve localized error
Translation-->>Validator: translated message
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 13-19: Update the README quick-start snippet to import or fully
qualify Rut, Iva, Clp, Phone, and Region from their Freshwork\ChileanBundle
namespaces so the example runs without class-not-found errors.
In `@src/Clp.php`:
- Around line 47-50: Update Clp::parse() to treat a minus sign as negative only
when it appears at the start of the amount, rather than using str_contains(),
while preserving digit extraction for valid formatted values. Add a regression
test covering a misplaced hyphen such as “1-234” and assert the expected parsing
behavior.
In `@src/Iva.php`:
- Around line 40-43: Define and document a single rounding policy for
Iva::add(), ensuring the net amount and IVA are combined before applying the
final rounding (or explicitly preserve the separate-rounding behavior). Update
the add() implementation and its documentation accordingly, and add a boundary
test covering a fractional input such as 1.4 against the documented expected
result.
In `@src/Phone.php`:
- Around line 55-63: Phone::normalize() currently strips arbitrary characters,
allowing malformed values through. Before removing formatting characters,
validate the original input against the permitted phone formatting characters
and reject unexpected characters; update Phone::check() and the cl_phone rule
behavior as needed, and add regression tests covering alphabetic and
text-prefixed inputs.
- Around line 110-115: The format() method currently assumes a one-digit area
code, causing valid landline numbers such as 452123456 to be formatted
incorrectly. Update format() to detect landline numbers and use the correct
two-digit area-code split, while preserving the existing formatting for other
number types.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9e3b0629-6961-41ad-90a5-e7d85808bd19
📒 Files selected for processing (13)
README.mdlang/en/validation.phplang/es/validation.phpsrc/Clp.phpsrc/Iva.phpsrc/Laravel/ChileanBundleServiceProvider.phpsrc/Phone.phpsrc/Region.phptests/Laravel/ValidationTest.phptests/Unit/ClpTest.phptests/Unit/IvaTest.phptests/Unit/PhoneTest.phptests/Unit/RegionTest.php
Comment on lines
+47
to
+50
| $negative = str_contains($amount, '-'); | ||
| $digits = (string) preg_replace('/[^0-9]/', '', $amount); | ||
|
|
||
| return ($negative ? -1 : 1) * (int) $digits; |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
git ls-files
printf '\n--- Clp.php outline ---\n'
ast-grep outline src/Clp.php --view expanded || true
printf '\n--- Clp.php lines ---\n'
cat -n src/Clp.php | sed -n '1,140p'
printf '\n--- tests/search for parse or hyphen cases ---\n'
rg -n "parse\(|Clp|1-234|negative|str_contains\\(\\$amount, '-'" src tests . || trueRepository: freshworkstudio/ChileanBundle
Length of output: 2777
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '%s\n' '--- tests/Unit/ClpTest.php ---'
cat -n tests/Unit/ClpTest.php
printf '\n%s\n' '--- README mentions CLP parse/format ---'
rg -n "Clp::parse|Clp::format|CLP|parse\\(" README.md src tests lang || true
printf '\n%s\n' '--- all references to Clp::parse ---'
rg -n "Clp::parse\\(" . || trueRepository: freshworkstudio/ChileanBundle
Length of output: 10850
Anchor the minus sign in Clp::parse()
str_contains($amount, '-') treats any hyphen as a negative sign, so 1-234 parses as -1234. Match only a leading sign or validate the full format, and add a regression test for misplaced hyphens.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/Clp.php` around lines 47 - 50, Update Clp::parse() to treat a minus sign
as negative only when it appears at the start of the amount, rather than using
str_contains(), while preserving digit extraction for valid formatted values.
Add a regression test covering a misplaced hyphen such as “1-234” and assert the
expected parsing behavior.
Comment on lines
+40
to
+43
| public static function add(int|float $net): int | ||
| { | ||
| return (int) round($net) + self::of($net); | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '--- src/Iva.php ---\n'
cat -n src/Iva.php
printf '\n--- search for Iva references ---\n'
rg -n "Iva::add\(|class Iva|nearest peso|round" src tests . -g '!vendor' -g '!node_modules' || trueRepository: freshworkstudio/ChileanBundle
Length of output: 258
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo '--- src/Iva.php ---'
cat -n src/Iva.php
echo
echo '--- Iva references ---'
rg -n "Iva::add\(|class Iva|nearest peso|round\(" src tests . -g '!vendor' -g '!node_modules' || trueRepository: freshworkstudio/ChileanBundle
Length of output: 4004
Use one rounding policy for Iva::add(). Iva::add() rounds the net amount and IVA separately, so float inputs can differ from rounding the gross total at the end (Iva::add(1.4) === 1 vs round(1.4 * 1.19) === 2). Define the intended behavior in the docs and add a boundary test.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/Iva.php` around lines 40 - 43, Define and document a single rounding
policy for Iva::add(), ensuring the net amount and IVA are combined before
applying the final rounding (or explicitly preserve the separate-rounding
behavior). Update the add() implementation and its documentation accordingly,
and add a boundary test covering a fractional input such as 1.4 against the
documented expected result.
- Clp::parse(): only a leading minus sign marks a negative amount - Iva::add(): round the net to the peso before calculating IVA (documented policy) - Phone::normalize(): reject input with unexpected characters instead of stripping them - Phone::format(): split two-digit area codes correctly for regional landlines - README: add missing use statements to the quick-start snippet Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WvDYWr2Tx3diCV3NXGrKRX
Member
Author
|
Addressed all 5 CodeRabbit findings in the latest commit: anchored minus sign in |
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second batch of the v2 work (follows #20): new Chilean utilities, each as its own cohesive class — no changes to
Rutor any existing signatures.New classes
Iva— Chilean VAT constants (RATE = 0.19,PERCENTAGE = 19) and calculations rounded to the nearest peso:Iva::of($net),Iva::add($net),Iva::net($gross),Iva::fromGross($gross).Clp— Chilean peso formatting:Clp::format(1234567)→'$1.234.567'(negatives and no-symbol supported) andClp::parse('$1.234.567')→1234567.Phone— Chilean phone validation/normalization: accepts+56 9 8765 4321,09-8765 4321,987654321, etc. Detects mobile vs landline, formats to E.164 and human-readable.Stringable.Region— int-backed enum with the 16 regions (official INE numbering):officialName(),romanNumeral()('RM'for Metropolitana),capital(),northToSouth()andoptions()for selects.Laravel
cl_phonevalidation rule with English/Spanish translations, consistent withcl_rut.Docs
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01WvDYWr2Tx3diCV3NXGrKRX
Summary by CodeRabbit
cl_phoneLaravel validation rule with localized English/Spanish messages.cl_phone.