feat: add non-extension session parity - #109
Merged
Merged
Conversation
- add managed/CDP profile capability tracking and session provenance diagnostics - keep Google user-owned auth limited to extension ops while improving provider routing - update docs, skills, public surface, and workflow evidence reviews - add regression coverage for profiles, target ownership, policy, and workflow parity Co-authored-by: Codex <noreply@openai.com>
- update final review recommendations after completed gates - preserve final evidence and authority notes Co-authored-by: Codex <noreply@openai.com>
- Move explicit CDP profile lifecycle into focused manager/helpers - Split session profile registry storage, validation, redaction, and summary seams - Preserve updated config behavior and harden explicit CDP process ownership cleanup Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenDevBrowser can now operate more reliably without the Chrome extension for owned browser/session continuity: explicit local CDP profiles have a first-class start/status/stop lifecycle, managed/direct sessions expose sanitized auth provenance, and provider workflows can distinguish browser state from actual auth proof before proceeding.
Google user-owned OAuth remains fail-closed to extension
/ops, while managed/CDP cookie continuity stays diagnostic rather than login proof. Inspiredesign/Pinterest readiness remains product-authority based: transport success is not enough without the required artifact and evidence authority surfaces.Review Notes
cdp-refactor-review-FFA9E4; no P0/P1/P2 blockers remained.BrowserManager.updateConfig()behavior, restored public mutable explicit-CDP types, and hardened process ownership/cleanup races.Verification
npm run test -- tests/explicit-cdp-profile-helpers.test.tsnpm run test -- tests/browser-manager.test.ts -t "explicit CDP profile"node scripts/run-package-tool.mjs eslint src/browser/explicit-cdp-profile-process.ts src/browser/explicit-cdp-profile-manager.ts tests/explicit-cdp-profile-helpers.test.ts tests/browser-manager.test.tsnpm run typecheckgit diff --checknode scripts/generate-public-surface-manifest.mjsnode scripts/docs-drift-check.mjsnpm run version:checkskills/opendevbrowser-best-practices/scripts/validate-skill-assets.shnpm run lintnpm run buildnpm run extension:buildnpm run testpassed with 302 test files passed, 1 skipped; 5,786 tests passed, 1 skipped; branch coverage 97.02%.node scripts/cli-smoke-test.mjscdp-profile start/status,connect --profile --disable-system-cookie-bootstrap,disconnect,cdp-profile stop, and daemon stop all passed with sanitized provenance, no forbidden token/path/ws/cookie-value leaks, and no leftover process lines.Post-Deploy Monitoring & Validation
cdp-profilestart/status/stop failures,daemon_fingerprint_mismatch, stale lease warnings, and explicit-CDP process ownership cleanup warnings.doNotProceedIfauth blockers.status --daemonreportsfingerprintCurrent === true; explicit-CDP lifecycle commands return success;authProvenancestays sanitized; Google user-owned auth attempts outside extension/opsfail closed.cdp-profile stop; Inspiredesign/Pinterest marks diagnostic-only evidence as product-ready.