Recover package versions from source archives - #91
Merged
Conversation
Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
added
the
cmd:skip-release-notes
github-actions
Bot
added
the
part:tooling
Marenz
marked this pull request as ready for review
August 4, 2026 10:50
Marenz
requested review from
florian-wagner-frequenz
and removed request for
a team
August 4, 2026 10:50
There was a problem hiding this comment.
Pull request overview
This PR adjusts the setuptools-scm configuration so package versions can be recovered when building a wheel from an sdist (where Git metadata is unavailable), aligning with the stated goal of making python -m build/rebuild workflows succeed for branch builds and tagged releases.
Changes:
- Configure
setuptools-scmto infer versions from the sdist’s parent directory name viaparentdir_prefix_version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ignore_missing_imports = true | ||
|
|
||
| [tool.setuptools_scm] | ||
| parentdir_prefix_version = "frequenz_client_marketmetering-" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m buildcreates the sdist successfully, but rebuilding the wheel from that archive fails becausesetuptools-scmno longer has Git metadata.Configure the generated sdist directory prefix as the version fallback. This fixes ordinary branch builds and tagged releases.
Verified with:
uv run --extra dev-noxfile noxuv builduv run --with twine twine check dist/*