Repository navigation
Add checking whether a device supports the button press - #1201
Merged
Merged
Conversation
Asking for a challenge shows it on the screen of the device right away, so it is no way to find out whether a device supports the flow. The new supported() only checks for the web interface of the device: an sa8 TIME serves it, an LM 37X8 TIME asks for credentials. Nothing shows on the screen. Verified on both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds
LaMetricLocalAuth.supported(), to find out whether a device can hand out its API key with a press on its button, without asking for it.Requesting a challenge shows it on the screen of the device right away, with a minute to press, so it is no way to probe for support.
supported()only checks for the web interface of the device that the button flow uses. Nothing shows on the screen.Verified on two real devices, with GET requests only:
supported()returnsTrue.supported()returnsFalse.This lets Home Assistant hide the button option for a device that cannot do it, or recommend it for one that can, as a follow up to home-assistant/core#184197.
Related Issues
Follow up on #1199.