Repository navigation
Do not fail the whole device on a Wi-Fi still connecting - #1200
Merged
Merged
Conversation
A real TIME, still (re)connecting to its Wi-Fi network, answered without active, ip and netmask, and with mac and ssid as null. That made the whole device fail to parse, taking the display, audio and everything else down with it until the next poll. Those Wi-Fi fields are optional now, so only the Wi-Fi details are missing while the device connects.
frenck
added
the
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
A real TIME, while (re)connecting to its Wi-Fi network, answered with a Wi-Fi block without
active,ipandnetmask, and withmacandssidasnull(home-assistant/core#97575). The whole device then failed to parse, taking the display, audio and everything else down with it until the next poll. In that issue the device recovered after two polls.Those five Wi-Fi fields are optional now, so only the Wi-Fi details are missing while the device connects.
availableandmodewere present in that answer and stay required.The fixture is a reconstruction, not a capture: the issue only has the validation error, which lists each field precisely. It is the LM 37X8 capture of the same generation with exactly those changes applied to its Wi-Fi block. Both real devices still parse their Wi-Fi block in full, from the device and the Wi-Fi endpoint.
Heads up for the Home Assistant integration: these fields can now be
None. It useswifi.macas the device connection in the device registry andwifi.ipfor the configuration URL. Taking the MAC from the config entry and the host it already connects to avoids both.Related Issues
home-assistant/core#97575