Repository navigation
Document what testing on real devices turned up - #1198
Merged
Merged
Conversation
A TIME accepts the screen_off screensaver mode, answering with success, but only switches its other modes off. The screensaver is then left without any mode at all. Only pick a mode the device reports. Streaming is not available on an LM 37X8 TIME on firmware 2.3.9, which reports API 2.3.0 and answers the stream endpoints with a 404. The docstring claimed API 2.3.0 was enough. The stream example now checks whether the device lists the stream endpoints first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Everything since v1.4.1 was run end to end against two real devices, an LM 37X8 TIME on firmware 2.3.9 and an sa8 TIME on firmware 3.2.6. All of it works, and both devices were left exactly as they were. Two things it turned up are worth documenting:
screen_offon a TIME is a trap. The device accepts the mode and answers with success, but it only switches its other modes off (herewhen_dark) and enables nothing. The screensaver is then left without any mode, without any error. Thedisplay()docstring now says to only pick a mode the device reports inscreensaver.modes.stream()docstring claimed API 2.3.0 was enough, but the LM 37X8 reports exactly API 2.3.0, lists no stream endpoints, and answers them with a 404. The sa8 (API 2.4.0) streams fine. The docstring and README now say so, and the stream example checks whether the device lists the stream endpoints before trying. Verified against both devices.Related Issues
None.