Repository navigation
Run the tests before publishing a release - #1195
Merged
Merged
Conversation
The release workflow went straight from installing to building and publishing to PyPI. Nothing stopped a release of a commit whose tests fail. Now the tests run first, and a failure stops the job before anything is built or published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The release workflow went straight from installing to building and publishing to PyPI, so nothing stopped a release of a commit whose tests fail. This runs the test suite first, with the same command as the tests workflow; a failure stops the job before anything is built or published.
Coverage is left out on purpose: CI already enforces the threshold on every pull request.
Related Issues
None.