Repository navigation
Document the SKY, the cloud client and streaming in the README - #1193
Merged
Merged
Conversation
The README only described controlling a LaMetric TIME on the local network. It now mentions the SKY, shows a short cloud example, and links the streaming example. The usage example imported a few enums from demetriek.models, which only worked because that module happens to import them. It now imports everything from the package itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The README only described controlling a LaMetric TIME on the local network. The library does more than that, so the README now:
examples/stream.py.The usage example also imported
NotificationIconTypeandNotificationSoundfromdemetriek.models, which only worked because that module happens to import them. It now imports everything fromdemetriekitself.Both README examples were run end to end against mocked responses.
Related Issues
None.