Repository navigation
Move the packages setting to where Poetry reads it - #1192
Merged
Merged
Conversation
The packages setting sat under [project], where Poetry ignores it. The package only got included because Poetry found it on its own. Under [tool.poetry] it is actually used. The built wheel is identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The
packagessetting sat under[project], where Poetry ignores it; it is not a standard project key. The package only got included because Poetry found it on its own insrc/. This moves it to[tool.poetry], where it is actually used, so a future change to it does what it says.No change to what gets published: the file list of the built wheel is identical before and after.
poetry check --lockpasses and the lock file is untouched.Related Issues
None.