Repository navigation
Make tests fail when the code they test does nothing - #1191
Merged
Merged
Conversation
The tests for switching to the next or previous app, and for showing a widget, never checked that a request was made. They kept passing with those methods replaced by no-ops. Nothing tested a volume or brightness of zero, or turning the display off. A truthiness check slipping in where `is not None` belongs would have quietly broken muting and switching off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Tests only, no library changes.
test_app_next,test_app_previousandtest_activate_widgetnever asserted a request was made, so they kept passing with those methods replaced by no-ops. They now assert the exact request.is not Nonebelongs would have quietly broken muting and switching the display off. Two new tests cover that.Verified by breaking the code on purpose (no-op methods, truthiness checks): all five tests fail against it.
Related Issues
None.