fix(ci): git-source gpui-form; patch gpui-query release build; clear lint drift

[hmziqagent]

Why master CI is red

Both failing runs (29828508874, 30356195053) died at workspace-manifest load on every job:

error: failed to load manifest for workspace member ...
Caused by: failed to load manifest for dependency `gpui-form`
Caused by: failed to read `/Users/hmziq/fo/form/crates/gpui-form/Cargo.toml`

bb628cb pointed the seven gpui-form* deps at absolute local paths; 2c3e5c2 deleted the vendored crates/. No runner (or other dev machine) can even run cargo metadata.

The fix — external sources, nothing vendored

gpui-form → git deps

All seven crates from freeoxide/gpui-form @ 8a373a9 (single checkout, no vendored files in this repo). That repo pins the identical zed gpui (1d217ee) and gpui-component (e416af7) revs as this workspace → one unified graph (verified in the lock), resolving to 0.5.2 — the exact version master's Cargo.lock always carried. crates.io is not an option: only the older 0.5.1 architecture is published there, and -schema / -component* / -codegen were never published at all.

gpui-query release build — second blocker hiding behind the first

cargo check --release (the Check job runs it; so does every release build) fails inside published gpui-query 0.1.4 — also 0.2.0 and upstream master: hook/query_hooks.rs's release-only #[cfg(not(debug_assertions))] fallback calls cx.new() without importing gpui::AppContext. Dev builds never compile that branch — which is how every green run masked it. The app cannot ship a release as-is.

Fix: [patch.crates-io] → hmziqagent/gpui-query @ f84eac4 (= tag v0.1.4 + the one-line cfg-gated import fix). Upstream PR: freeoxide/gpui-query#11 — once a fixed release ships, delete the patch line. scripts/toggle-gpui-query.sh now enforces exactly-one-active-line in the marker block (default git rev ↔ standalone Mac checkout; two active keys = TOML error).

Clippy / fmt (audit-sweep drift, never validated by CI)

• #[allow(clippy::double_must_use)] on NotificationBackend — new nightly lint on #[async_trait]'s generated #[must_use] wrappers.
• cargo fmt --all over 20 files of drift.

Release pipeline (ships broken artifacts; not exercised by CI runs)

• gen-pkgbuild.sh: bake the releasing repo into the PKGBUILD's ${REPO:-…} default — release.yml's REPO env was dead code (heredoc escaping), so fork-cut releases ship PKGBUILDs whose source= URL 404s.
• gen-pkgbuild.sh package(): prefix paths with gpui-starter/ to match the tarball's nested layout (install was hitting the directory; lib/ was silently skipped).

Validation (local, nightly 2026-08-16 — mirrors every CI job)

CI job	Local equivalent	Result
Check (dev)	cargo check	✅
Check (release)	cargo check --release	✅ (was ❌ pre-patch)
Clippy ×2	cargo clippy -- -D warnings	✅ (was ❌ pre-fix)
Formatting	cargo fmt --all -- --check	✅ (was ❌ pre-fix)
Test (lib)	cargo test -p gpui-starter --lib	✅ 187 passed, 0 failed

Lock verified: single gpui-component rev, single es-fluent family, gpui-form* all 0.5.2 from one git checkout, gpui-query 0.1.4+fix from the pinned patch rev.

Known residuals (documented, deliberately not "fixed" here)

• Test job's 30-min timeout on a guaranteed-cold cache — PR fix(tests): break gpui #[test] glob-shadow; repair lib test suite #3's cold run fit; if it times out, raise timeout-minutes.
• RUST_MIN_STACK stays removed from release jobs (deliberate, documented, root cause fixed).
• ⚠️ Moving parts outside this repo: freeoxide/gpui-form@8a373a9 (pin bumps are now explicit rev changes) and hmziqagent/gpui-query@f84eac4 (retire after fix: import AppContext for release-profile cx.new() in use_query_manual gpui-query#11 ships in a release).

🤖 Generated with Claude Code