Repository navigation
fix(capabilities): remove consolidated uFlow/uKnowledge repo requirements - #40
Merged
Merged
Conversation
…quirements uFlow and uKnowledge are consolidated internal subsystems of uCore (under app.flow and app.knowledge) rather than standalone git checkouts under ~/Code. Remove legacy repo requirements for workflow.run, knowledge.search, and developer.guided, and add preflight/readiness integration tests.
There was a problem hiding this comment.
🟡 Changes recommended
Tests do not deterministically verify the requirement changes, and existing user-level overrides are not migrated.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates capability requirements after consolidating uFlow and uKnowledge into uCore, with added preflight integration tests.
Changes:
- Removes obsolete repository requirements.
- Adds capability readiness and preflight tests.
File summaries
| File | Summary |
|---|---|
config/capability_requirements.json |
Removes stale uFlow/uKnowledge repository dependencies. |
backend/tests/test_capabilities_preflight.py |
Adds preflight and batch readiness tests. |
Review details
Suppressed comments (2)
backend/tests/test_capabilities_preflight.py:54
- This test is not deterministic in the repository's backend CI environment:
developer.guidedstill requires theuCoderepo, but CI setsUDOS_ROOTto the workspace parent while checking out uCode atexternal/uCode, so_evaluate_capabilitychecks for<workspace-parent>/uCodeand returns a missing-repo repair. Provision the required repo paths in the fixture or update the backend job layout before assertingreadyhere.
assert data["capability"] == "knowledge.search"
assert data["ready"] is True
assert data["repair_required"] is False
assert data["repair"] == []
async def test_developer_guided_preflight_excludes_uflow_and_uknowledge(self):
resp = await self.client.get("/api/capabilities/developer.guided/preflight")
data = await resp.json()
config/capability_requirements.json:5
- This changes only the repository fallback file, but
_load_capability_requirements()preferssettings.config_dir / "capability_requirements.json"whenever that user-level override exists (backend/app/api/extensions_api.py:35-46). Existing installations with the stale copied requirements file will therefore continue to report missinguFlow/uKnowledgerepositories, so the stated fix does not propagate to the deployment path used by those installations. Add an explicit config migration/update or otherwise define how existing overrides are refreshed.
"repos": [],
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… and add schema test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uFlowanduKnowledgeas separate external repositories under~/Code.uFlowanduKnowledgewere merged intouCoreon 2026-09-12 (underbackend/app/flowandbackend/app/knowledge) and their extensions (uflowanduknowledge) are loaded internally byuCore.config/capability_requirements.jsonfor:workflow.run: removerepos: ["uFlow"], keeping extensionuflowand toolgit.knowledge.search: removerepos: ["uKnowledge"], keeping extensionuknowledge.developer.guided: removeuFlowanduKnowledgefrom repos list, retaining["uCore", "uCode"].backend/tests/test_capabilities_preflight.pyverifying 200/ready responses for both single preflight endpoints and batch readiness snapshots.Verification
GET /api/capabilities/workflow.run/preflight->{"ready": true, "repair_required": false, "repair": []}GET /api/capabilities/knowledge.search/preflight->{"ready": true, "repair_required": false, "repair": []}GET /api/capabilities/developer.guided/preflight->{"ready": true, "repair_required": false, "repair": []}python3 scripts/check_home_path_policy.pypython3 scripts/validate_capability_requirements.pybash scripts/validate_planning_governance.shpython3 scripts/validate_docs_nonregression.pyPYTHONPATH=backend python3 scripts/check_documentation_route_contract.pypython3 scripts/validate_extension_manifests.pypython3 scripts/audit_duplicate_routes.pypython3 scripts/validate_legacy_settings_cleanup.pybackend/tests/test_capabilities_preflight.pypassed.