implement favorites functionality - #3
Merged
Merged
Conversation
-add plan for favorites menu. -Add persistent named favorites without coupling storage to the viewer -Add persistent named favorites through an isolated storage and UI feature -Document named favorites and their keyboard shortcuts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-add plan for favorites menu.
-Add persistent named favorites without coupling storage to the viewer -Add persistent named favorites through an isolated storage and UI feature -Document named favorites and their keyboard shortcuts
What does this change do, and why?
add a favorites menu, the user can give the currently loaded list of images a name and save it to the menu.
How was this tested?
unit tests + human e2e test.
Checklist
gofmt -l .is clean,go vet ./...andgo test -race ./...passlang.L, with the key added to everybundle in
translations/internal/ui/help/manual.mdandmanual_de.mdupdated, if thischanges documented behavior
ARCHITECTURE.mdupdated, if this changes the package structuretodos.mdinstead