Fix crash deleting the last image in a multi-file set - #2
Merged
Conversation
RemoveFile trimmed v.files but never adjusted v.index, so deleting while viewing the last image left v.index pointing past the shrunk slice - the next CurrentFile() call then indexed out of range and crashed the app. Clamp v.index in RemoveFile when it now points past the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveFile trimmed v.files but never adjusted v.index, so deleting while viewing the last image left v.index pointing past the shrunk slice - the next CurrentFile() call then indexed out of range and crashed the app. Clamp v.index in RemoveFile when it now points past the end.
What does this change do, and why?
Fixes a crash when the last image in a list that is currently displayed gets deleted.
Added regression test.
How was this tested?
existing test suit + flame test on Linux and MacOS
Checklist
gofmt -l .is clean,go vet ./...andgo test -race ./...passlang.L, with the key added to everybundle in
translations/internal/ui/help/manual.mdandmanual_de.mdupdated, if thischanges documented behavior
ARCHITECTURE.mdupdated, if this changes the package structuretodos.mdinstead