chore: convert raw sql - #451
Open
fproldan wants to merge 3 commits into
Open
Conversation
Confidence Score: 5/5Safe to merge — all query translations are logically correct and the previous LEFT-JOIN and filter bugs are fixed. Every converted query preserves the original semantics: filters, joins, grouping, and return shapes all match. No functional regressions introduced. No files require special attention. Reviews (2): Last reviewed commit: "fix: _get_items_to_migrate" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
fproldan
marked this pull request as draft
July 10, 2026 13:34
fproldan
marked this pull request as ready for review
July 10, 2026 13:43
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a member of the AgriTheory team, which maintains a number of Frappe and ERPNext apps. We're in the process of migrating them to version-16, and part of that process is updating any SQL queries in the code to support PostgreSQL in addition to MariaDB. As some of our apps use other Frappe apps as a dependency, we figured we'd help in the effort here.
This PR converts the remaining frappe.db.sql calls with MariaDB-specific syntax (backtick-quoted table names) into database-agnostic calls.