fix(scraper): resolve relative links against the post-redirect URL - #9
Merged
Merged
Conversation
fetch_links_from_url now returns the effective URL (response.geturl()) and process_url uses it as the base for urljoin. Without this, scraping a URL that redirects - e.g. a GitHub Pages project page where '/repo' 301-redirects to '/repo/' - resolved relative links one directory too high, causing 404s on every file. Add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: scraping a URL that 301-redirects (e.g. a GitHub Pages project page:
/repo->/repo/) resolved relative links one directory too high, so every file 404'd.Fix:
fetch_links_from_urlreturns the effective URL (response.geturl());process_urluses it as theurljoinbase.Reproduced locally with an http.server that redirects
/MetaDetective->/MetaDetective/: before, all files 404; after, the lab files download correctly. 58 unit tests pass (added a regression test).