fix(controlplane): limit public invite token lookup response#2671
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a87ec47. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
user_existsboolean and omits raw invite tokens/internal IDs from the public lookup responseTest plan
go test ./services -run TestFindUserByInviteTokenService_Rungo test ./api -run 'TestOrganisationInviteIntegrationTestSuite/Test_FindUserByInviteToken'golangci-lint run ./api/... ./services/...go vet ./...git diff --checkNote
Medium Risk
Breaking change on a public auth-related endpoint; clients must adopt the new shape, though exposure of tokens and PII is reduced.
Overview
Tightens the unauthenticated invite-token lookup so it no longer returns full
userrecords or rawOrganisationInviteentities.The handler now responds with
InviteTokenLookupResponse: a trimmedtokenobject (org name, invitee email, role, status only),user_exists, and optionalfirst_name/last_namewhen the invitee already has an account. Integration tests assert the JSON omits the invite secret, internal IDs, timestamps, and the nesteduserobject. The accept-invite dashboard flow readsuser_existsand top-level names, and existing users no longer send name fields when accepting.Swagger/OpenAPI artifacts were regenerated (includes broader schema churn beyond this endpoint).
Reviewed by Cursor Bugbot for commit 023bad3. Bugbot is set up for automated code reviews on this repo. Configure here.