Fix onTransitionStart and onTransitionEnd in StackView - #1
Open
fr1n63 wants to merge 41 commits into
Open
Conversation
These functions weren't firing anymore as they are passed as part of navigationConfig. Not sure if this is the best way to fix, but it solves my issue.
…eact-navigation#4106) * Use Array.prototype.findIndex instead of map => indexOf Creating a new array and iterating over all the routes is inefficient compared to findIndex, which does not create a new array and exits as soon as it finds a match. Since the indexOf method is used extensively this should provide a minor performance improvement * reverted yarn.lock edits
…ion#4102) * add test for 2856 * rename variables
Events were getting unsubscribed too early, so that the inner willBlur event was getting skipped when trying to “dismiss” a deep navigation stack.
“reset” is not a NavigationAction anymore. The correct fix, for v3, to this is to navigate to the first screen inside the stack. With the less-pushy navigate behavior in v2, this will result in the first route getting selected if you specify it by routeName.
Addresses react-navigation#4129, and also lets child routers swallow actions with null. Tests added
* 3127: Fixed gestureDirectionInverted variable declaration and condition in onPanResponderMove method in regards to swipe back action in RTL mode. * - 4118: Put axis check first; - Fixed default BackButton mask in RTL mode.
Previously we had been emiting an action event with a null state when the router handles the action by returning null from getStateForAction. - Fixes the case of null state getting emitted - Renames a few things for clarity - Refactors conditionals to read easier - Comments to explain intent
* fix swipe gesture bug * panresponder as instance prop
This really is not ideal but it's an upstream bug on react-native Android that we can't work around. Users may experience other unexpected behavior as a result of this upstream bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions weren't firing anymore as they are passed as part of navigationConfig. Not sure if this is the best way to fix, but it solves my issue.